Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread Eric Dumazet
On Wed, 2013-07-10 at 08:21 +0300, Eliezer Tamir wrote: > Where do I find the repository for the manpages? > MAN-PAGES: MANUAL PAGES FOR LINUX -- Sections 2, 3, 4, 5, and 7 M: Michael Kerrisk W: http://www.kernel.org/doc/man-pages L: linux-...@vger.kernel.org S: Maintained

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread Eliezer Tamir
On 10/07/2013 07:41, David Miller wrote: > From: Eliezer Tamir > Date: Wed, 10 Jul 2013 06:29:16 +0300 > >> If the following names changes are acceptable I will try to send out >> a patch today. >> 2. ndo_ll_poll -> ndo_busy_poll >> >> - not technically accurate since the ndo callback does not i

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread David Miller
From: Eliezer Tamir Date: Wed, 10 Jul 2013 06:29:16 +0300 > If the following names changes are acceptable I will try to send out > a patch today. > > 1. include/net/ll_poll.h -> include/net/busy_poll.h Agreed. > 2. ndo_ll_poll -> ndo_busy_poll > > - not technically accurate since the ndo call

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread Eliezer Tamir
On 10/07/2013 02:06, David Miller wrote: > From: Jonathan Corbet > Date: Tue, 9 Jul 2013 16:25:14 -0600 > >> On Mon, 08 Jul 2013 16:20:34 +0300 >> Eliezer Tamir wrote: >> >>> Rename POLL_LL to POLL_BUSY_LOOP. >> >> So pardon me if I speak out of turn, but it occurs to me to >> wonder...should th

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread David Miller
From: Jonathan Corbet Date: Tue, 9 Jul 2013 16:25:14 -0600 > On Mon, 08 Jul 2013 16:20:34 +0300 > Eliezer Tamir wrote: > >> Rename POLL_LL to POLL_BUSY_LOOP. > > So pardon me if I speak out of turn, but it occurs to me to > wonder...should the SO_LL socket option be renamed in a similar fashio

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-09 Thread Jonathan Corbet
On Mon, 08 Jul 2013 16:20:34 +0300 Eliezer Tamir wrote: > Rename POLL_LL to POLL_BUSY_LOOP. So pardon me if I speak out of turn, but it occurs to me to wonder...should the SO_LL socket option be renamed in a similar fashion before this interface escapes into the wild? Thanks, jon -- To unsubsc

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread David Miller
From: Linus Torvalds Date: Mon, 8 Jul 2013 12:37:06 -0700 > I think it's getting closer, and I'm ok with the last final details > being sorted out later. I just can't reasonably test any of my > suggestions, so I'd like to get it to a point where when I pull, I > don't feel like I'm pulling core

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Linus Torvalds
On Mon, Jul 8, 2013 at 1:05 PM, Stephen Hemminger wrote: >> > >> > unsigned long start_time = 0; >> > ... >> > if (want_busy_poll && !need_resched()) { >> > unsigned long now = busy_poll_sched_clock(); >> > if (!start_time) { >> > start_time = now + sysctl.b

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Stephen Hemminger
On Mon, 08 Jul 2013 22:46:04 +0300 Eliezer Tamir wrote: > On 08/07/2013 22:37, Linus Torvalds wrote: > > On Mon, Jul 8, 2013 at 10:14 AM, Eliezer Tamir > > wrote: > >> > >> I think there is no way for the compiler to know the value of > >> can_busy_loop at compile time. It depends on the replies

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Stephen Hemminger
On Mon, 08 Jul 2013 22:46:04 +0300 Eliezer Tamir wrote: > On 08/07/2013 22:37, Linus Torvalds wrote: > > On Mon, Jul 8, 2013 at 10:14 AM, Eliezer Tamir > > wrote: > >> > >> I think there is no way for the compiler to know the value of > >> can_busy_loop at compile time. It depends on the replies

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Eliezer Tamir
On 08/07/2013 22:37, Linus Torvalds wrote: > On Mon, Jul 8, 2013 at 10:14 AM, Eliezer Tamir > wrote: >> >> I think there is no way for the compiler to know the value of >> can_busy_loop at compile time. It depends on the replies we get >> from polling the sockets. ll_flag was there to make sure th

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Linus Torvalds
On Mon, Jul 8, 2013 at 10:14 AM, Eliezer Tamir wrote: > > I think there is no way for the compiler to know the value of > can_busy_loop at compile time. It depends on the replies we get > from polling the sockets. ll_flag was there to make sure the compiler > will know when things are defined out.

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Eliezer Tamir
On 08/07/2013 19:37, Linus Torvalds wrote: > On Mon, Jul 8, 2013 at 6:20 AM, Eliezer Tamir > wrote: >> >> - /* only if on, have sockets with POLL_LL and not out of time >> */ >> - if (ll_flag && can_ll && can_poll_ll(ll_start, ll_time)) >> + /* only if fo

Re: [PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Linus Torvalds
On Mon, Jul 8, 2013 at 6:20 AM, Eliezer Tamir wrote: > > - /* only if on, have sockets with POLL_LL and not out of time > */ > - if (ll_flag && can_ll && can_poll_ll(ll_start, ll_time)) > + /* only if found POLL_BUSY_LOOP sockets && not out of time */ > +

[PATCH net-next] net: rename low latency sockets functions to busy poll

2013-07-08 Thread Eliezer Tamir
Rename functions in include/net/ll_poll.h to busy wait. Clarify documentation about expected power use increase. Rename POLL_LL to POLL_BUSY_LOOP. Add need_resched() testing to poll/select busy loops. Note, that in select and poll can_busy_poll is dynamic and is updated continuously to reflect the