Re: [PATCH net-next] net: virtio: unify code to init stats

2024-06-21 Thread Jakub Kicinski
On Thu, 20 Jun 2024 03:44:53 -0400 Michael S. Tsirkin wrote: > Moving initialization of stats structure into > __free_old_xmit reduces the code size slightly. > It also makes it clearer that this function shouldn't > be called multiple times on the same stats struct. > > Signed-off-by: Michael S.

Re: [PATCH net-next] net: virtio: unify code to init stats

2024-06-20 Thread Heng Qi
在 2024/6/20 下午3:44, Michael S. Tsirkin 写道: Moving initialization of stats structure into __free_old_xmit reduces the code size slightly. It also makes it clearer that this function shouldn't be called multiple times on the same stats struct. Signed-off-by: Michael S. Tsirkin --- Especially i

Re: [PATCH net-next] net: virtio: unify code to init stats

2024-06-20 Thread Xuan Zhuo
On Thu, 20 Jun 2024 03:44:53 -0400, "Michael S. Tsirkin" wrote: > Moving initialization of stats structure into > __free_old_xmit reduces the code size slightly. > It also makes it clearer that this function shouldn't > be called multiple times on the same stats struct. > > Signed-off-by: Michael

[PATCH net-next] net: virtio: unify code to init stats

2024-06-20 Thread Michael S. Tsirkin
Moving initialization of stats structure into __free_old_xmit reduces the code size slightly. It also makes it clearer that this function shouldn't be called multiple times on the same stats struct. Signed-off-by: Michael S. Tsirkin --- Especially important now that Jiri's patch for BQL has been