Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Andrew Lunn
On Fri, Jul 10, 2020 at 11:41:25AM -0400, min.li...@renesas.com wrote: > From: Min Li > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > It will create a debugfs directory called idtptp{x} and x is the ptp index. > Three inerfaces are present, which are cmd, help and

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 11:38:39AM -0700, Richard Cochran wrote: > On Sat, Jul 11, 2020 at 06:38:06PM +0200, Andrew Lunn wrote: > > But configuration does not belong in debugfs. It would be good to > > explain what is being configured by these parameters, then we can > > maybe make a suggestion abo

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Richard Cochran
On Sat, Jul 11, 2020 at 06:38:06PM +0200, Andrew Lunn wrote: > But configuration does not belong in debugfs. It would be good to > explain what is being configured by these parameters, then we can > maybe make a suggestion about the correct API to use. Can we at least enumerate the possibilities?

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 06:46:01AM -0700, Richard Cochran wrote: > On Fri, Jul 10, 2020 at 01:58:44PM -0700, Jakub Kicinski wrote: > > On Fri, 10 Jul 2020 11:41:25 -0400 min.li...@renesas.com wrote: > > > From: Min Li > > > > > > This patch is to add debugfs support for ptp_clockmatrix and ptp_id

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-11 Thread Richard Cochran
On Fri, Jul 10, 2020 at 01:58:44PM -0700, Jakub Kicinski wrote: > On Fri, 10 Jul 2020 11:41:25 -0400 min.li...@renesas.com wrote: > > From: Min Li > > > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > > It will create a debugfs directory called idtptp{x} and x is th

Re: [PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-10 Thread Jakub Kicinski
On Fri, 10 Jul 2020 11:41:25 -0400 min.li...@renesas.com wrote: > From: Min Li > > This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. > It will create a debugfs directory called idtptp{x} and x is the ptp index. > Three inerfaces are present, which are cmd, help and regs.

[PATCH net-next] ptp: add debugfs support for IDT family of timing devices

2020-07-10 Thread min.li.xe
From: Min Li This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33. It will create a debugfs directory called idtptp{x} and x is the ptp index. Three inerfaces are present, which are cmd, help and regs. help is read only and will display a brief help message. regs is read only