Re: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-04 Thread David Miller
From: Hayes Wang Date: Mon, 2 Sep 2019 19:52:28 +0800 > First, for AUTONEG_DISABLE, we only need to modify MII_BMCR. > > Second, add advertising parameter for rtl8152_set_speed(). Add > RTL_ADVERTISED_xxx for advertising parameter of rtl8152_set_speed(). > Then, the advertising settings from

RE: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-03 Thread Hayes Wang
Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Tuesday, September 03, 2019 3:13 PM [...] > > Some of our chips support the feature of UPS. When satisfying certain > > condition, the hw would recover the settings of speed. Therefore, I have > > to record the settings of the speed, and set

Re: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-03 Thread Heiner Kallweit
On 03.09.2019 08:55, Hayes Wang wrote: > Heiner Kallweit [mailto:hkallwe...@gmail.com] >> Sent: Tuesday, September 03, 2019 2:45 PM > [...] >>> Besides, I have a question. I think I don't need rtl8152_set_speed() >>> if I implement phylib. However, I need to record some information >>> according

RE: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-03 Thread Hayes Wang
Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Tuesday, September 03, 2019 2:45 PM [...] > > Besides, I have a question. I think I don't need rtl8152_set_speed() > > if I implement phylib. However, I need to record some information > > according to the settings of speed. For now, I do it in

Re: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-03 Thread Heiner Kallweit
On 03.09.2019 08:36, Hayes Wang wrote: > Heiner Kallweit [mailto:hkallwe...@gmail.com] >> Sent: Tuesday, September 03, 2019 2:14 PM > [...] Seeing all this code it might be a good idea to switch this driver to phylib, similar to what I did with r8169 some time ago. >>> >>> It is too

RE: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-03 Thread Hayes Wang
Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Tuesday, September 03, 2019 2:14 PM [...] > >> Seeing all this code it might be a good idea to switch this driver > >> to phylib, similar to what I did with r8169 some time ago. > > > > It is too complex to be completed for me at the moment. >

Re: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-03 Thread Heiner Kallweit
On 03.09.2019 05:16, Hayes Wang wrote: > Heiner Kallweit [mailto:hkallwe...@gmail.com] >> Sent: Tuesday, September 03, 2019 2:37 AM > [...] >> Seeing all this code it might be a good idea to switch this driver >> to phylib, similar to what I did with r8169 some time ago. > > It is too complex to

RE: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-02 Thread Hayes Wang
Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Tuesday, September 03, 2019 2:37 AM [...] > Seeing all this code it might be a good idea to switch this driver > to phylib, similar to what I did with r8169 some time ago. It is too complex to be completed for me at the moment. If this patch

Re: [PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-02 Thread Heiner Kallweit
On 02.09.2019 13:52, Hayes Wang wrote: > First, for AUTONEG_DISABLE, we only need to modify MII_BMCR. > > Second, add advertising parameter for rtl8152_set_speed(). Add > RTL_ADVERTISED_xxx for advertising parameter of rtl8152_set_speed(). > Then, the advertising settings from ethtool could be

[PATCH net-next] r8152: modify rtl8152_set_speed function

2019-09-02 Thread Hayes Wang
First, for AUTONEG_DISABLE, we only need to modify MII_BMCR. Second, add advertising parameter for rtl8152_set_speed(). Add RTL_ADVERTISED_xxx for advertising parameter of rtl8152_set_speed(). Then, the advertising settings from ethtool could be saved. Signed-off-by: Hayes Wang ---