Re: [PATCH net-next] sctp: deduplicate identical skb_checksum_ops

2019-05-30 Thread David Miller
From: Matteo Croce Date: Wed, 29 May 2019 17:39:41 +0200 > The same skb_checksum_ops struct is defined twice in two different places, > leading to code duplication. Declare it as a global variable into a common > header instead of allocating it on the stack on each function call. > bloat-o-meter

Re: [PATCH net-next] sctp: deduplicate identical skb_checksum_ops

2019-05-29 Thread Marcelo Ricardo Leitner
On Wed, May 29, 2019 at 05:39:41PM +0200, Matteo Croce wrote: > The same skb_checksum_ops struct is defined twice in two different places, > leading to code duplication. Declare it as a global variable into a common > header instead of allocating it on the stack on each function call. > bloat-o-met

Re: [PATCH net-next] sctp: deduplicate identical skb_checksum_ops

2019-05-29 Thread Neil Horman
On Wed, May 29, 2019 at 05:39:41PM +0200, Matteo Croce wrote: > The same skb_checksum_ops struct is defined twice in two different places, > leading to code duplication. Declare it as a global variable into a common > header instead of allocating it on the stack on each function call. > bloat-o-met

[PATCH net-next] sctp: deduplicate identical skb_checksum_ops

2019-05-29 Thread Matteo Croce
The same skb_checksum_ops struct is defined twice in two different places, leading to code duplication. Declare it as a global variable into a common header instead of allocating it on the stack on each function call. bloat-o-meter reports a slight code shrink. add/remove: 1/1 grow/shrink: 0/10 up