Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Jason Wang
On 2017年02月19日 13:08, Michael S. Tsirkin wrote: - oxdp_qp = vi->xdp_queue_pairs; - /* Changing the headroom in buffers is a disruptive operation because * existing buffers must be flushed and reallocated. This will happen * when a xdp program is initially added

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Jason Wang
On 2017年02月19日 13:08, Michael S. Tsirkin wrote: - oxdp_qp = vi->xdp_queue_pairs; - /* Changing the headroom in buffers is a disruptive operation because * existing buffers must be flushed and reallocated. This will happen * when a xdp program is initially added

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Michael S. Tsirkin
On Fri, Feb 17, 2017 at 03:30:51PM -0800, John Fastabend wrote: > On 17-02-16 09:10 PM, Jason Wang wrote: > > > > > > On 2017年02月17日 12:53, John Fastabend wrote: > >> On 17-02-15 01:08 AM, Jason Wang wrote: > >>> We set queues before reset which will cause a crash[1]. This is > >>> because

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-19 Thread Michael S. Tsirkin
On Fri, Feb 17, 2017 at 03:30:51PM -0800, John Fastabend wrote: > On 17-02-16 09:10 PM, Jason Wang wrote: > > > > > > On 2017年02月17日 12:53, John Fastabend wrote: > >> On 17-02-15 01:08 AM, Jason Wang wrote: > >>> We set queues before reset which will cause a crash[1]. This is > >>> because

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-18 Thread Michael S. Tsirkin
On Fri, Feb 17, 2017 at 01:10:08PM +0800, Jason Wang wrote: > > > On 2017年02月17日 12:53, John Fastabend wrote: > > On 17-02-15 01:08 AM, Jason Wang wrote: > > > We set queues before reset which will cause a crash[1]. This is > > > because is_xdp_raw_buffer_queue() depends on the old xdp queue

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-18 Thread Michael S. Tsirkin
On Fri, Feb 17, 2017 at 01:10:08PM +0800, Jason Wang wrote: > > > On 2017年02月17日 12:53, John Fastabend wrote: > > On 17-02-15 01:08 AM, Jason Wang wrote: > > > We set queues before reset which will cause a crash[1]. This is > > > because is_xdp_raw_buffer_queue() depends on the old xdp queue

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-17 Thread John Fastabend
On 17-02-16 09:10 PM, Jason Wang wrote: > > > On 2017年02月17日 12:53, John Fastabend wrote: >> On 17-02-15 01:08 AM, Jason Wang wrote: >>> We set queues before reset which will cause a crash[1]. This is >>> because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs >>> number to do the

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-17 Thread John Fastabend
On 17-02-16 09:10 PM, Jason Wang wrote: > > > On 2017年02月17日 12:53, John Fastabend wrote: >> On 17-02-15 01:08 AM, Jason Wang wrote: >>> We set queues before reset which will cause a crash[1]. This is >>> because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs >>> number to do the

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread Jason Wang
On 2017年02月17日 12:53, John Fastabend wrote: On 17-02-15 01:08 AM, Jason Wang wrote: We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by: - set queues after

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread Jason Wang
On 2017年02月17日 12:53, John Fastabend wrote: On 17-02-15 01:08 AM, Jason Wang wrote: We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by: - set queues after

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread John Fastabend
On 17-02-15 01:08 AM, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by: > > - set queues after reset, to keep the old

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread John Fastabend
On 17-02-15 01:08 AM, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by: > > - set queues after reset, to keep the old

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 05:08:09PM +0800, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by: > > - set queues after reset, to keep the old

Re: [PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-16 Thread Michael S. Tsirkin
On Wed, Feb 15, 2017 at 05:08:09PM +0800, Jason Wang wrote: > We set queues before reset which will cause a crash[1]. This is > because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs > number to do the correct detection. So fix this by: > > - set queues after reset, to keep the old

[PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-15 Thread Jason Wang
We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by: - set queues after reset, to keep the old vi->curr_queue_pairs. (in fact setting queues before reset does not

[PATCH net-next] virito-net: set queues after reset during xdp_set

2017-02-15 Thread Jason Wang
We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by: - set queues after reset, to keep the old vi->curr_queue_pairs. (in fact setting queues before reset does not