Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

2017-01-03 Thread Andrew Lunn
> Well, I agree with the regression part, but an argument could > definitively be made that HWMON did not belong in the DSA layer in the > first place, unless we were able to find some commonality between > devices which AFAICT, we could not yet. Florian, does SF2 or b53 have a temperature sensor?

Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

2017-01-03 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: The current HWMON support in DSA in embedded in the legacy code. Extract it to its own file and register it in the newer DSA code. >>> >>> I would really prefer not to do this. >>> >>> The temperature sensor is in the embedded PHYs of the switch. Ma

Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

2017-01-03 Thread Florian Fainelli
On 01/03/2017 11:24 AM, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > >> On Tue, Jan 03, 2017 at 01:15:35PM -0500, Vivien Didelot wrote: >>> The current HWMON support in DSA in embedded in the legacy code. >>> Extract it to its own file and register it in the newer DSA code. >> >>

Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

2017-01-03 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Tue, Jan 03, 2017 at 01:15:35PM -0500, Vivien Didelot wrote: >> The current HWMON support in DSA in embedded in the legacy code. >> Extract it to its own file and register it in the newer DSA code. > > I would really prefer not to do this. > > The temperature

Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

2017-01-03 Thread Andrew Lunn
On Tue, Jan 03, 2017 at 01:15:35PM -0500, Vivien Didelot wrote: > The current HWMON support in DSA in embedded in the legacy code. > Extract it to its own file and register it in the newer DSA code. Hi Vivien I would really prefer not to do this. The temperature sensor is in the embedded PHYs of

[PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2

2017-01-03 Thread Vivien Didelot
The current HWMON support in DSA in embedded in the legacy code. Extract it to its own file and register it in the newer DSA code. Tested on ZII Rev B boards. Vivien Didelot (3): net: dsa: remove out label in dsa_switch_setup_one net: dsa: move HWMON support to its own file net: dsa: restor