Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-17 Thread tanhuazhong
On 2019/10/17 23:47, Jakub Kicinski wrote: On Thu, 17 Oct 2019 11:27:09 +0800, tanhuazhong wrote: On 2019/10/17 1:50, David Miller wrote: From: Jakub Kicinski Date: Wed, 16 Oct 2019 10:19:43 -0700 On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: This patch-set includes some

Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-17 Thread Jakub Kicinski
On Thu, 17 Oct 2019 11:27:09 +0800, tanhuazhong wrote: > On 2019/10/17 1:50, David Miller wrote: > > From: Jakub Kicinski > > Date: Wed, 16 Oct 2019 10:19:43 -0700 > > > >> On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: > >>> This patch-set includes some bugfixes and code

Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-16 Thread tanhuazhong
On 2019/10/17 1:50, David Miller wrote: From: Jakub Kicinski Date: Wed, 16 Oct 2019 10:19:43 -0700 On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: This patch-set includes some bugfixes and code optimizations for the HNS3 ethernet controller driver. The code LGTM, mostly, but it

Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-16 Thread tanhuazhong
On 2019/10/17 1:50, David Miller wrote: From: Jakub Kicinski Date: Wed, 16 Oct 2019 10:19:43 -0700 On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: This patch-set includes some bugfixes and code optimizations for the HNS3 ethernet controller driver. The code LGTM, mostly, but it

Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-16 Thread tanhuazhong
On 2019/10/17 1:19, Jakub Kicinski wrote: On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: This patch-set includes some bugfixes and code optimizations for the HNS3 ethernet controller driver. The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4 should be a separate

Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-16 Thread David Miller
From: Jakub Kicinski Date: Wed, 16 Oct 2019 10:19:43 -0700 > On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: >> This patch-set includes some bugfixes and code optimizations >> for the HNS3 ethernet controller driver. > > The code LGTM, mostly, but it certainly seems like patches 2, 3

Re: [PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-16 Thread Jakub Kicinski
On Wed, 16 Oct 2019 15:16:59 +0800, Huazhong Tan wrote: > This patch-set includes some bugfixes and code optimizations > for the HNS3 ethernet controller driver. The code LGTM, mostly, but it certainly seems like patches 2, 3 and 4 should be a separate series targeting the net tree :(

[PATCH net-next 00/12] net: hns3: add some bugfixes and optimizations

2019-10-16 Thread Huazhong Tan
This patch-set includes some bugfixes and code optimizations for the HNS3 ethernet controller driver. [patch 01/12] removes unused and unnecessary structures. [patch 02/12] fixes a TX queue not restarted problem. [patch 03/12] fixes a use-after-free issue. [patch 04/12] fixes a mis-counting