Re: [PATCH net-next 01/11] net: dsa: make EEE ops optional

2017-08-01 Thread Andrew Lunn
Hi Vivien > @@ -646,38 +646,42 @@ static int dsa_slave_set_eee(struct net_device *dev, > struct ethtool_eee *e) > { > struct dsa_slave_priv *p = netdev_priv(dev); > struct dsa_switch *ds = p->dp->ds; > - int ret; > + int err = -ENODEV; > > - if (!ds->ops->set_eee) > -

[PATCH net-next 01/11] net: dsa: make EEE ops optional

2017-07-31 Thread Vivien Didelot
Even though EEE implies the port's PHY and MAC of both ends, a switch may not need to do anything to configure the port's MAC. This makes it impossible for the DSA layer to distinguish e.g. this case from a disabled EEE when a driver returns 0 from the get EEE operation. For this reason, make the