Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread David Miller
From: Joe Perches Date: Tue, 03 Mar 2015 12:04:28 -0800 > On Tue, 2015-03-03 at 14:58 -0500, David Miller wrote: >> From: Joe Perches >> Date: Tue, 03 Mar 2015 11:41:09 -0800 >> >> Converting these locations to consistently use eth_*() is fine, >> but then "optimizing" a 6 by memset for configu

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 14:58 -0500, David Miller wrote: > From: Joe Perches > Date: Tue, 03 Mar 2015 11:41:09 -0800 > > > Until such time as the linux crosstools compilers are updated, > > (they seem stuck on 4.6.3 from 3 years ago) > > https://www.kernel.org/pub/tools/crosstool/ > > I think the s

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread David Miller
From: Joe Perches Date: Tue, 03 Mar 2015 11:41:09 -0800 > Until such time as the linux crosstools compilers are updated, > (they seem stuck on 4.6.3 from 3 years ago) > https://www.kernel.org/pub/tools/crosstool/ > I think the series is a trivial, small improvement. You are even admitting that e

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Eric Dumazet
On Tue, 2015-03-03 at 11:41 -0800, Joe Perches wrote: > Until such time as the linux crosstools compilers are updated, > (they seem stuck on 4.6.3 from 3 years ago) > https://www.kernel.org/pub/tools/crosstool/ > I think the series is a trivial, small improvement. > > I believe that's the only "a

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 14:27 -0500, David Miller wrote: > From: Joe Perches > Date: Tue, 03 Mar 2015 11:07:51 -0800 > > On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote: > >> On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > >> > >> > At least for arm gcc 4.6.3, it emits different code

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread David Miller
From: Eric Dumazet Date: Tue, 03 Mar 2015 10:42:05 -0800 > On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > >> At least for arm gcc 4.6.3, it emits different code >> for net/l2tp/l2tp_eth.o > > Then it looks like arm gcc or arm linux memset() should be improved. > > Tracking all memset(

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread David Miller
From: Joe Perches Date: Tue, 03 Mar 2015 11:07:51 -0800 > On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote: >> On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: >> >> > At least for arm gcc 4.6.3, it emits different code >> > for net/l2tp/l2tp_eth.o >> >> Then it looks like arm gcc or

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote: > On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > > > At least for arm gcc 4.6.3, it emits different code > > for net/l2tp/l2tp_eth.o > > Then it looks like arm gcc or arm linux memset() should be improved. Perhaps you can take that

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Eric Dumazet
On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: > At least for arm gcc 4.6.3, it emits different code > for net/l2tp/l2tp_eth.o Then it looks like arm gcc or arm linux memset() should be improved. Tracking all memset(x, y, 6) and replace them by some custom version seems not very generic t

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Joe Perches
On Tue, 2015-03-03 at 05:19 -0800, Eric Dumazet wrote: > On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: > > Make the memset possibly more efficient with the appropriate > > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS #ifdef [] > > diff --git a/include/linux/etherdevice.h b/include/linux/etherdevi

Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-03 Thread Eric Dumazet
On Mon, 2015-03-02 at 19:54 -0800, Joe Perches wrote: > Make the memset possibly more efficient with the appropriate > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS #ifdef > > Signed-off-by: Joe Perches > --- > include/linux/etherdevice.h | 12 +++- > 1 file changed, 11 insertions(+), 1 deletio

[PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code

2015-03-02 Thread Joe Perches
Make the memset possibly more efficient with the appropriate CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS #ifdef Signed-off-by: Joe Perches --- include/linux/etherdevice.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/include/linux/etherdevice.h b/include/linux/ether