Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere

2019-10-21 Thread Vivien Didelot
Hi Andrew, On Mon, 21 Oct 2019 14:31:49 +0200, Andrew Lunn wrote: > On Sat, Oct 19, 2019 at 11:19:26PM -0400, Vivien Didelot wrote: > > Do not let the drivers access the ds->ports static array directly > > while there is a dsa_to_port helper for this purpose. > > > > At the same time, un-const t

Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere

2019-10-21 Thread Andrew Lunn
On Sat, Oct 19, 2019 at 11:19:26PM -0400, Vivien Didelot wrote: > Do not let the drivers access the ds->ports static array directly > while there is a dsa_to_port helper for this purpose. > > At the same time, un-const this helper since the SJA1105 driver > assigns the priv member of the returned

Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere

2019-10-20 Thread Florian Fainelli
On 10/19/2019 8:19 PM, Vivien Didelot wrote: > Do not let the drivers access the ds->ports static array directly > while there is a dsa_to_port helper for this purpose. > > At the same time, un-const this helper since the SJA1105 driver > assigns the priv member of the returned dsa_port structu

[PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere

2019-10-19 Thread Vivien Didelot
Do not let the drivers access the ds->ports static array directly while there is a dsa_to_port helper for this purpose. At the same time, un-const this helper since the SJA1105 driver assigns the priv member of the returned dsa_port structure. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b