Re: [PATCH net-next 08/15] rxrpc: Fix call timer

2016-09-23 Thread David Howells
Sergei Shtylyov wrote: > > + if (call->timer.expires != t || !timer_pending(&call->timer)) { > > mod_timer(&call->timer, t); > > } > >CodingStyle: {} not needed now. See patch 11. David

Re: [PATCH net-next 08/15] rxrpc: Fix call timer

2016-09-23 Thread Sergei Shtylyov
On 09/23/2016 06:16 PM, David Howells wrote: Fix the call timer in the following ways: (1) If call->resend_at or call->ack_at are before or equal to the current time, then ignore that timeout. (2) If call->expire_at is before or equal to the current time, then don't set the timer a

[PATCH net-next 08/15] rxrpc: Fix call timer

2016-09-23 Thread David Howells
Fix the call timer in the following ways: (1) If call->resend_at or call->ack_at are before or equal to the current time, then ignore that timeout. (2) If call->expire_at is before or equal to the current time, then don't set the timer at all (possibly we should queue the call). (3)