Re: [PATCH net-next 1/4] enetc: drop unneeded indirection

2020-12-16 Thread Vladimir Oltean
On Tue, Dec 15, 2020 at 10:21:57PM +0100, Michael Walle wrote: > Before commit 6517798dd343 ("enetc: Make MDIO accessors more generic and > export to include/linux/fsl") these macros actually had some benefits. > But after the commit it just makes the code hard to read. Drop the macro > indirection

Re: [PATCH net-next 1/4] enetc: drop unneeded indirection

2020-12-15 Thread Andrew Lunn
On Tue, Dec 15, 2020 at 10:21:57PM +0100, Michael Walle wrote: > Before commit 6517798dd343 ("enetc: Make MDIO accessors more generic and > export to include/linux/fsl") these macros actually had some benefits. > But after the commit it just makes the code hard to read. Drop the macro > indirection

[PATCH net-next 1/4] enetc: drop unneeded indirection

2020-12-15 Thread Michael Walle
Before commit 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") these macros actually had some benefits. But after the commit it just makes the code hard to read. Drop the macro indirections. Signed-off-by: Michael Walle --- .../net/ethernet/freescale/enetc