Hi Vivien
> +static int mv88e6xxx_set_port_mode_normal(struct mv88e6xxx_chip *chip, int
> port)
> +{
> + return mv88e6xxx_set_port_mode(chip, port, MV88E6XXX_FRAME_MODE_NORMAL,
> +PORT_CONTROL_EGRESS_UNMODIFIED, 0x9100);
It would be nice to replace this
Hi Vivien
> +static int mv88e6xxx_set_port_mode_normal(struct mv88e6xxx_chip *chip, int
> port)
> +{
> + return mv88e6xxx_set_port_mode(chip, port, MV88E6XXX_FRAME_MODE_NORMAL,
> +PORT_CONTROL_EGRESS_UNMODIFIED, 0x9100);
It would be nice to replace this
A switch port mode is defined by the association of its egress mode, its
frame mode and if supported or required, the ether type value.
Pack all this in a mv88e6xxx_set_port_mode function and provide helpers
for the Normal Network mode, the DSA mode, and the Ether Type DSA mode,
as well as an
A switch port mode is defined by the association of its egress mode, its
frame mode and if supported or required, the ether type value.
Pack all this in a mv88e6xxx_set_port_mode function and provide helpers
for the Normal Network mode, the DSA mode, and the Ether Type DSA mode,
as well as an
4 matches
Mail list logo
