Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-10 Thread Eli Cohen
On Thu, Feb 07, 2019 at 10:01:10AM -0800, David Miller wrote: > From: Eli Cohen > Date: Thu, 7 Feb 2019 09:45:49 +0200 > > > diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c > > index 902957beceb3..d54cb608dbaf 100644 > > --- a/net/sched/act_simple.c > > +++ b/net/sched/act_simple.c

Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-08 Thread Jiri Pirko
Fri, Feb 08, 2019 at 09:01:42AM CET, simon.hor...@netronome.com wrote: >On Thu, Feb 07, 2019 at 09:45:49AM +0200, Eli Cohen wrote: >> Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For >> example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with >> TCA_ID_POLICE and

Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-08 Thread Simon Horman
On Thu, Feb 07, 2019 at 09:45:49AM +0200, Eli Cohen wrote: > Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For > example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with > TCA_ID_POLICE and also differentiates these identifier, used in struct > tc_action_ops type

Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-07 Thread David Miller
From: Eli Cohen Date: Thu, 7 Feb 2019 09:45:49 +0200 > diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c > index 902957beceb3..d54cb608dbaf 100644 > --- a/net/sched/act_simple.c > +++ b/net/sched/act_simple.c > @@ -19,8 +19,6 @@ > #include > #include > > -#define TCA_ACT_SIMP

[PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-06 Thread Eli Cohen
Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with TCA_ID_POLICE and also differentiates these identifier, used in struct tc_action_ops type field, from other macros starting with TCA_ACT_. To make things