Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-15 Thread Vladimir Oltean
On Sun, Feb 14, 2021 at 09:48:53PM +0100, Michael Walle wrote: > Am 2021-02-14 03:24, schrieb Vladimir Oltean: > > On Sun, Feb 14, 2021 at 03:18:49AM +0100, Michael Walle wrote: > > > Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean > > > : > > > >Hi Michael, > > > > > > > >On Sun, Feb

Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-14 Thread Michael Walle
Am 2021-02-14 03:24, schrieb Vladimir Oltean: On Sun, Feb 14, 2021 at 03:18:49AM +0100, Michael Walle wrote: Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean : >Hi Michael, > >On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote: >> at803x_aneg_done() checks if

Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-13 Thread Vladimir Oltean
On Sun, Feb 14, 2021 at 03:18:49AM +0100, Michael Walle wrote: > Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean : > >Hi Michael, > > > >On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote: > >> at803x_aneg_done() checks if auto-negotiation is completed on the > >SGMII > >>

Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-13 Thread Michael Walle
Am 14. Februar 2021 02:57:33 MEZ schrieb Vladimir Oltean : >Hi Michael, > >On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote: >> at803x_aneg_done() checks if auto-negotiation is completed on the >SGMII >> side. This doesn't take the mdio bus lock and the page switching is >>

Re: [PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-13 Thread Vladimir Oltean
Hi Michael, On Sun, Feb 14, 2021 at 02:04:05AM +0100, Michael Walle wrote: > at803x_aneg_done() checks if auto-negotiation is completed on the SGMII > side. This doesn't take the mdio bus lock and the page switching is > open-coded. Now that we have proper page support, just use >

[PATCH net-next 2/2] net: phy: at803x: use proper locking in at803x_aneg_done()

2021-02-13 Thread Michael Walle
at803x_aneg_done() checks if auto-negotiation is completed on the SGMII side. This doesn't take the mdio bus lock and the page switching is open-coded. Now that we have proper page support, just use phy_read_paged(). Also use phydev->interface to check if we have an SGMII link instead of reading