Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-31 Thread Tao Ren
On 7/30/19 10:55 PM, Tao Ren wrote: > On 7/30/19 7:34 PM, Andrew Lunn wrote: >>> Hi Andrew, >>> >>> The BCM54616S PHY on my machine is connected to a BCM5396 switch chip over >>> backplane (1000Base-KX). >> >> Ah, that is different. So the board is using it for RGMII to 1000Base-KX? >> >>

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Tao Ren
On 7/30/19 7:34 PM, Andrew Lunn wrote: >> Hi Andrew, >> >> The BCM54616S PHY on my machine is connected to a BCM5396 switch chip over >> backplane (1000Base-KX). > > Ah, that is different. So the board is using it for RGMII to 1000Base-KX? > > phy-mode is about the MAC-PHY link. So in this case

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Andrew Lunn
> Hi Andrew, > > The BCM54616S PHY on my machine is connected to a BCM5396 switch chip over > backplane (1000Base-KX). Ah, that is different. So the board is using it for RGMII to 1000Base-KX? phy-mode is about the MAC-PHY link. So in this case RGMII. There is no DT way to configure the

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Tao Ren
On 7/30/19 6:36 PM, Andrew Lunn wrote: >> The INTF_SEL pins report correct mode (RGMII-Fiber) on my machine, >> but there are 2 "sub-modes" (1000Base-X and 100Base-FX) and I >> couldn't find a proper/safe way to auto-detect which "sub-mode" is >> active. The datasheet just describes instructions

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Andrew Lunn
> The INTF_SEL pins report correct mode (RGMII-Fiber) on my machine, > but there are 2 "sub-modes" (1000Base-X and 100Base-FX) and I > couldn't find a proper/safe way to auto-detect which "sub-mode" is > active. The datasheet just describes instructions to enable a > specific mode, but it doesn't

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Tao Ren
On 7/30/19 6:17 AM, Andrew Lunn wrote: >> Again, I don't think Linux has generic support for overwriting (or >> even describing) the operating mode of a PHY, although maybe that's a >> direction we would want to push the discussion towards. RGMII to >> copper, RGMII to fiber, SGMII to copper,

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Tao Ren
On 7/30/19 3:15 AM, Vladimir Oltean wrote: > On Tue, 30 Jul 2019 at 07:52, Tao Ren wrote: >> >> On 7/29/19 6:32 PM, Vladimir Oltean wrote: >>> Hi Tao, >>> >>> On Tue, 30 Jul 2019 at 03:31, Tao Ren wrote: Configure the BCM54616S for 1000Base-X mode when "brcm-phy-mode-1000bx" is

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Andrew Lunn
> Again, I don't think Linux has generic support for overwriting (or > even describing) the operating mode of a PHY, although maybe that's a > direction we would want to push the discussion towards. RGMII to > copper, RGMII to fiber, SGMII to copper, copper to fiber (media > converter), even RGMII

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-30 Thread Vladimir Oltean
On Tue, 30 Jul 2019 at 07:52, Tao Ren wrote: > > On 7/29/19 6:32 PM, Vladimir Oltean wrote: > > Hi Tao, > > > > On Tue, 30 Jul 2019 at 03:31, Tao Ren wrote: > >> > >> Configure the BCM54616S for 1000Base-X mode when "brcm-phy-mode-1000bx" > >> is set in device tree. This is needed when the PHY

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-29 Thread Tao Ren
On 7/29/19 6:32 PM, Vladimir Oltean wrote: > Hi Tao, > > On Tue, 30 Jul 2019 at 03:31, Tao Ren wrote: >> >> Configure the BCM54616S for 1000Base-X mode when "brcm-phy-mode-1000bx" >> is set in device tree. This is needed when the PHY is used for fiber and >> backplane connections. >> >> The

Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S

2019-07-29 Thread Vladimir Oltean
Hi Tao, On Tue, 30 Jul 2019 at 03:31, Tao Ren wrote: > > Configure the BCM54616S for 1000Base-X mode when "brcm-phy-mode-1000bx" > is set in device tree. This is needed when the PHY is used for fiber and > backplane connections. > > The patch is inspired by commit cd9af3dac6d1 ("PHYLIB: Add