Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

2018-04-24 Thread Christian Brauner
On Tue, Apr 24, 2018 at 03:39:25PM -0400, David Miller wrote: > From: Christian Brauner > Date: Mon, 23 Apr 2018 12:24:43 +0200 > > > + #ifdef CONFIG_NET > > + seqnum = get_ns_uevent_seqnum_by_vpid(); > > + #else > > + seqnum = uevent_seqnum;

Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

2018-04-24 Thread Christian Brauner
On Tue, Apr 24, 2018 at 03:39:25PM -0400, David Miller wrote: > From: Christian Brauner > Date: Mon, 23 Apr 2018 12:24:43 +0200 > > > + #ifdef CONFIG_NET > > + seqnum = get_ns_uevent_seqnum_by_vpid(); > > + #else > > + seqnum = uevent_seqnum; > > + #endif > > Please

Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

2018-04-24 Thread David Miller
From: Christian Brauner Date: Mon, 23 Apr 2018 12:24:43 +0200 > + #ifdef CONFIG_NET > + seqnum = get_ns_uevent_seqnum_by_vpid(); > + #else > + seqnum = uevent_seqnum; > + #endif Please don't indend the code like this. By

Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

2018-04-24 Thread David Miller
From: Christian Brauner Date: Mon, 23 Apr 2018 12:24:43 +0200 > + #ifdef CONFIG_NET > + seqnum = get_ns_uevent_seqnum_by_vpid(); > + #else > + seqnum = uevent_seqnum; > + #endif Please don't indend the code like this. By indenting the CPP directives, which

[PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

2018-04-23 Thread Christian Brauner
Now that it's possible to have a different set of uevents in different network namespaces, per-network namespace uevent sequence numbers are introduced. This increases performance as locking is now restricted to the network namespace affected by the uevent rather than locking everything. Testing

[PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

2018-04-23 Thread Christian Brauner
Now that it's possible to have a different set of uevents in different network namespaces, per-network namespace uevent sequence numbers are introduced. This increases performance as locking is now restricted to the network namespace affected by the uevent rather than locking everything. Testing