Re: [PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 12:53:37PM +0200, Matteo Croce wrote: > On Wed, Oct 23, 2019 at 12:00 PM Simon Horman > wrote: > > On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote: > > > + switch (ih->type) { > > > + case ICMP_ECHO: > > > + case ICMP_ECHOREPLY: > > > + case

Re: [PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-23 Thread Matteo Croce
On Wed, Oct 23, 2019 at 12:00 PM Simon Horman wrote: > On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote: > > + switch (ih->type) { > > + case ICMP_ECHO: > > + case ICMP_ECHOREPLY: > > + case ICMP_TIMESTAMP: > > + case ICMP_TIMESTAMPREPLY: > > + case

Re: [PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-23 Thread Simon Horman
On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote: > The ICMP flow dissector currently parses only the Type and Code fields. > Some ICMP packets (echo, timestamp) have a 16 bit Identifier field which > is used to correlate packets. > Add such field in flow_dissector_key_icmp and replace

[PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-21 Thread Matteo Croce
The ICMP flow dissector currently parses only the Type and Code fields. Some ICMP packets (echo, timestamp) have a 16 bit Identifier field which is used to correlate packets. Add such field in flow_dissector_key_icmp and replace skb_flow_get_be16() with a more complex function which populate this