RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

From: Florian Fainelli > Sent: 28 July 2017 18:05 ... > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); > >>> > >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? > >> > >> I have no opinion. I just used the same variant as the other EXPORTS > >> in the file. > > > > If there is no concern

RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

From: Florian Fainelli > Sent: 28 July 2017 18:05 ... > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); > >>> > >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? > >> > >> I have no opinion. I just used the same variant as the other EXPORTS > >> in the file. > > > > If there is no concern

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Den 28. juli 2017 23:28, skrev Andrew Lunn: Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem to be appropriate, which can be done as a subsequent patch. Reviewed-by: Florian Fainelli I have no idea how these legalities work. But for the record, I

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Den 28. juli 2017 23:28, skrev Andrew Lunn: Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem to be appropriate, which can be done as a subsequent patch. Reviewed-by: Florian Fainelli I have no idea how these legalities work. But for the record, I give consent to change

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

> >Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem > >to be appropriate, which can be done as a subsequent patch. > > > >Reviewed-by: Florian Fainelli > > > I have no idea how these legalities work. But for the record, > I give consent to change to

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

> >Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem > >to be appropriate, which can be done as a subsequent patch. > > > >Reviewed-by: Florian Fainelli > > > I have no idea how these legalities work. But for the record, > I give consent to change to EXPORT_SYMBOL_GPL at any

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Den 28. juli 2017 19:05, skrev Florian Fainelli: On 07/28/2017 09:55 AM, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write =

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Den 28. juli 2017 19:05, skrev Florian Fainelli: On 07/28/2017 09:55 AM, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +};

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

On 07/28/2017 09:55 AM, Vivien Didelot wrote: > Hi Egil, > > Egil Hjelmeland writes: > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +};

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

On 07/28/2017 09:55 AM, Vivien Didelot wrote: > Hi Egil, > > Egil Hjelmeland writes: > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +};

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Hi Egil, Egil Hjelmeland writes: >>> +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { >>> + .phy_read = lan9303_indirect_phy_read, >>> + .phy_write = lan9303_indirect_phy_write, >>> +}; >>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops); >> >> Isn't

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Hi Egil, Egil Hjelmeland writes: >>> +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { >>> + .phy_read = lan9303_indirect_phy_read, >>> + .phy_write = lan9303_indirect_phy_write, >>> +}; >>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops); >> >> Isn't EXPORT_SYMBOL_GPL prefered over

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Den 28. juli 2017 17:39, skrev Vivien Didelot: Hi Egil, Egil Hjelmeland writes: +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +};

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Den 28. juli 2017 17:39, skrev Vivien Didelot: Hi Egil, Egil Hjelmeland writes: +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +}; +EXPORT_SYMBOL(lan9303_indirect_phy_ops); Isn't

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Hi Egil, Egil Hjelmeland writes: > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { > + .phy_read = lan9303_indirect_phy_read, > + .phy_write = lan9303_indirect_phy_write, > +}; > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); Isn't EXPORT_SYMBOL_GPL

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Hi Egil, Egil Hjelmeland writes: > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { > + .phy_read = lan9303_indirect_phy_read, > + .phy_write = lan9303_indirect_phy_write, > +}; > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

On Fri, Jul 28, 2017 at 05:11:57PM +0200, Egil Hjelmeland wrote: > Indirect access (PMI) to phy register only work in I2C mode. In > MDIO mode phy registers must be accessed directly. Introduced > struct lan9303_phy_ops to handle the two modes. > > Signed-off-by: Egil Hjelmeland

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

On Fri, Jul 28, 2017 at 05:11:57PM +0200, Egil Hjelmeland wrote: > Indirect access (PMI) to phy register only work in I2C mode. In > MDIO mode phy registers must be accessed directly. Introduced > struct lan9303_phy_ops to handle the two modes. > > Signed-off-by: Egil Hjelmeland Reviewed-by:

[PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Indirect access (PMI) to phy register only work in I2C mode. In MDIO mode phy registers must be accessed directly. Introduced struct lan9303_phy_ops to handle the two modes. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 20 +---

[PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Indirect access (PMI) to phy register only work in I2C mode. In MDIO mode phy registers must be accessed directly. Introduced struct lan9303_phy_ops to handle the two modes. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 20 +--- drivers/net/dsa/lan9303.h