Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-08-03 Thread Joe Stringer
On 31 July 2015 at 19:08, Pravin Shelar wrote: > On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer wrote: >> +static void prepare_frag(struct vport *vport, struct sw_flow_key *key, >> +struct sk_buff *skb) >> +{ >> + unsigned int hlen = ETH_HLEN; >> + struct ovs_f

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Pravin Shelar
On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer wrote: > Expose the kernel connection tracker via OVS. Userspace components can > make use of the "ct()" action, followed by "recirculate", to populate > the conntracking state in the OVS flow key, and subsequently match on > that state. > > Example O

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Joe Stringer
On 31 July 2015 at 08:26, Hannes Frederic Sowa wrote: > On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: >> +static void do_output(struct datapath *dp, struct sk_buff *skb, int >> out_port, >> + struct sw_flow_key *key) >> { >> struct vport *vport = ovs_vport_rcu(dp,

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Joe Stringer
Thanks for review, On 31 July 2015 at 07:52, Hannes Frederic Sowa wrote: > On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: >> +static void prepare_frag(struct vport *vport, struct sw_flow_key >> *key, >> + struct sk_buff *skb) >> +{ >> + unsigned int hlen = ETH_HLE

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Hannes Frederic Sowa
On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: > +static void do_output(struct datapath *dp, struct sk_buff *skb, int > out_port, > + struct sw_flow_key *key) > { > struct vport *vport = ovs_vport_rcu(dp, out_port); > > - if (likely(vport)) > - ovs

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-31 Thread Hannes Frederic Sowa
Hi, On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c > index e50678d..4a62ed4 100644 > --- a/net/openvswitch/actions.c > +++ b/net/openvswitch/actions.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include

[PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-30 Thread Joe Stringer
Expose the kernel connection tracker via OVS. Userspace components can make use of the "ct()" action, followed by "recirculate", to populate the conntracking state in the OVS flow key, and subsequently match on that state. Example ODP flows allowing traffic from 1->2, only replies from 2->1: in_po