Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-04 Thread Shannon Nelson
On 2/3/2017 2:11 PM, Eric Dumazet wrote: Transmit completion might happen on another cpu, regardless of ldom. Therefore you need smp_rmb() here ( like mellanox/mlx4/en_tx.c) , or even smp_mb() as bnx2x does. dma_rmb() is never used in this context. In that case, it looks like there are a co

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Eric Dumazet
On Fri, 2017-02-03 at 13:20 -0800, Shannon Nelson wrote: > On 2/3/2017 9:56 AM, Eric Dumazet wrote: > > On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: > >> In order to allow the underlying LDC and outstanding memory operations > >> to potentially catch up with the driver's Tx requests, ad

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread David Miller
From: Shannon Nelson Date: Fri, 3 Feb 2017 13:20:43 -0800 > On 2/3/2017 9:56 AM, Eric Dumazet wrote: >> On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: >>> In order to allow the underlying LDC and outstanding memory operations >>> to potentially catch up with the driver's Tx requests, ad

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Shannon Nelson
On 2/3/2017 9:56 AM, Eric Dumazet wrote: On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors.

Re: [PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Eric Dumazet
On Fri, 2017-02-03 at 09:42 -0800, Shannon Nelson wrote: > In order to allow the underlying LDC and outstanding memory operations > to potentially catch up with the driver's Tx requests, add a memory > barrier before checking again for available tx descriptors. > > Signed-off-by: Shannon Nelson >

[PATCH net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-03 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c |1 + 1 files cha