Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-04 Thread Andrew Lunn
> > What we don't want is a window of time during the fabric setup as a > > whole is inconsistent, and frames a leaking out ports they should not. > > There is no such window. Hi Vivien Great, that is what i wanted to hear. Thanks Andrew

Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-04 Thread Andrew Lunn
> > What we don't want is a window of time during the fabric setup as a > > whole is inconsistent, and frames a leaking out ports they should not. > > There is no such window. Hi Vivien Great, that is what i wanted to hear. Thanks Andrew

Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-04 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +#define DSA_NOTIFIER_BRIDGE_JOIN1 >> +#define DSA_NOTIFIER_BRIDGE_LEAVE 2 > > Is one notifier per event sufficient? Yes. What a switch chip in a fabric needs to know is what action is currently triggered on another chip,

Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-04 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +#define DSA_NOTIFIER_BRIDGE_JOIN1 >> +#define DSA_NOTIFIER_BRIDGE_LEAVE 2 > > Is one notifier per event sufficient? Yes. What a switch chip in a fabric needs to know is what action is currently triggered on another chip, so that it can

Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-04 Thread Andrew Lunn
> +#define DSA_NOTIFIER_BRIDGE_JOIN 1 > +#define DSA_NOTIFIER_BRIDGE_LEAVE2 Hi Vivien Is one notifier per event sufficient? I've not looked at what actually needs to happen when a port joins a bridge, in a D in DSA setup. Do we need to both enable the flow of frames

Re: [PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-04 Thread Andrew Lunn
> +#define DSA_NOTIFIER_BRIDGE_JOIN 1 > +#define DSA_NOTIFIER_BRIDGE_LEAVE2 Hi Vivien Is one notifier per event sufficient? I've not looked at what actually needs to happen when a port joins a bridge, in a D in DSA setup. Do we need to both enable the flow of frames

[PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-03 Thread Vivien Didelot
A slave device will now notify the switch fabric once its port is bridged or unbridged, instead of calling directly its switch operations. This code allows propagating cross-chip bridging events in the fabric. Signed-off-by: Vivien Didelot ---

[PATCH net-next 6/6] net: dsa: introduce bridge notifier

2017-02-03 Thread Vivien Didelot
A slave device will now notify the switch fabric once its port is bridged or unbridged, instead of calling directly its switch operations. This code allows propagating cross-chip bridging events in the fabric. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 10 ++ net/dsa/slave.c