Hi Andrew,
Andrew Lunn writes:
>> /* Transmit function may have to reallocate the original SKB */
>> -nskb = p->xmit(skb, dev);
>> +nskb = p->dp->ds->dst->tag_ops->xmit(skb, dev);
>
> This is also the hot path for DSA transmit. Do we really want to do 4
> extra
Hi Andrew,
Andrew Lunn writes:
>> /* Transmit function may have to reallocate the original SKB */
>> -nskb = p->xmit(skb, dev);
>> +nskb = p->dp->ds->dst->tag_ops->xmit(skb, dev);
>
> This is also the hot path for DSA transmit. Do we really want to do 4
> extra pointer dereferences
On Tue, May 30, 2017 at 10:21:30AM -0400, Vivien Didelot wrote:
> The dsa_slave_priv structure holds a copy of the dsa_device_ops xmit
> function. It is always assigned to the switch tree xmit function.
>
> Remove this useless copy.
>
> Signed-off-by: Vivien Didelot
On Tue, May 30, 2017 at 10:21:30AM -0400, Vivien Didelot wrote:
> The dsa_slave_priv structure holds a copy of the dsa_device_ops xmit
> function. It is always assigned to the switch tree xmit function.
>
> Remove this useless copy.
>
> Signed-off-by: Vivien Didelot
> ---
> net/dsa/dsa_priv.h
The dsa_slave_priv structure holds a copy of the dsa_device_ops xmit
function. It is always assigned to the switch tree xmit function.
Remove this useless copy.
Signed-off-by: Vivien Didelot
---
net/dsa/dsa_priv.h | 3 ---
net/dsa/slave.c| 4 +---
2
The dsa_slave_priv structure holds a copy of the dsa_device_ops xmit
function. It is always assigned to the switch tree xmit function.
Remove this useless copy.
Signed-off-by: Vivien Didelot
---
net/dsa/dsa_priv.h | 3 ---
net/dsa/slave.c| 4 +---
2 files changed, 1 insertion(+), 6
6 matches
Mail list logo