Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-02-01 Thread Alex Elder
On 2/1/21 8:47 AM, Willem de Bruijn wrote: - I will begin some long testing later today without this last patch applied --> But I think testing without the IRQ ordering patch would be more promising, and I'd like to hear your opinion on that Either test depends on whe

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-02-01 Thread Alex Elder
On 2/1/21 8:47 AM, Willem de Bruijn wrote: I tried to do a survey of that too and did not see a consistent pattern. I didn't look*that* hard because doing so would be more involved than I wanted to get. Okay. If there is no consistent pattern, either approach works. I'm fine with this patchse

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-02-01 Thread Willem de Bruijn
On Mon, Feb 1, 2021 at 9:35 AM Alex Elder wrote: > > On 1/31/21 7:36 PM, Willem de Bruijn wrote: > > On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: > >> > >> On 1/31/21 8:52 AM, Willem de Bruijn wrote: > >>> On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > > On 1/30/21 9:25 AM,

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-02-01 Thread Alex Elder
On 1/31/21 7:36 PM, Willem de Bruijn wrote: On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: On 1/31/21 8:52 AM, Willem de Bruijn wrote: On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: On 1/30/21 9:25 AM, Willem de Bruijn wrote: On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: Th

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: > > On 1/31/21 8:52 AM, Willem de Bruijn wrote: > > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > >> > >> On 1/30/21 9:25 AM, Willem de Bruijn wrote: > >>> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > > The channel stop a

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Alex Elder
On 1/31/21 8:52 AM, Willem de Bruijn wrote: > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: >> >> On 1/30/21 9:25 AM, Willem de Bruijn wrote: >>> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: The channel stop and suspend paths both call __gsi_channel_stop(), which quiesces

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > > On 1/30/21 9:25 AM, Willem de Bruijn wrote: > > On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > >> > >> The channel stop and suspend paths both call __gsi_channel_stop(), > >> which quiesces channel activity, disables NAPI, and (on other

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Alex Elder
On 1/30/21 10:29 PM, Alex Elder wrote: > On 1/30/21 9:25 AM, Willem de Bruijn wrote: >> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: >>> >>> The channel stop and suspend paths both call __gsi_channel_stop(), >>> which quiesces channel activity, disables NAPI, and (on other than >>> SDM845) st

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-30 Thread Alex Elder
On 1/30/21 1:22 PM, Jakub Kicinski wrote: On Sat, 30 Jan 2021 10:25:16 -0500 Willem de Bruijn wrote: @@ -894,12 +894,16 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id) struct gsi_channel *channel = &gsi->channel[channel_id]; int ret; - /* Enable the completion

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-30 Thread Alex Elder
On 1/30/21 9:25 AM, Willem de Bruijn wrote: On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: The channel stop and suspend paths both call __gsi_channel_stop(), which quiesces channel activity, disables NAPI, and (on other than SDM845) stops the channel. Similarly, the start and resume paths

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-30 Thread Jakub Kicinski
On Sat, 30 Jan 2021 10:25:16 -0500 Willem de Bruijn wrote: > > @@ -894,12 +894,16 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id) > > struct gsi_channel *channel = &gsi->channel[channel_id]; > > int ret; > > > > - /* Enable the completion interrupt */ > > + /*

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-30 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > > The channel stop and suspend paths both call __gsi_channel_stop(), > which quiesces channel activity, disables NAPI, and (on other than > SDM845) stops the channel. Similarly, the start and resume paths > share __gsi_channel_start(), which sta

[PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-29 Thread Alex Elder
The channel stop and suspend paths both call __gsi_channel_stop(), which quiesces channel activity, disables NAPI, and (on other than SDM845) stops the channel. Similarly, the start and resume paths share __gsi_channel_start(), which starts the channel and re-enables NAPI again. Disabling NAPI sh