Re: [PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-10 Thread Aya Levin
On 9/8/2020 5:04 PM, Jiri Pirko wrote: Sun, Sep 06, 2020 at 05:44:28PM CEST, ido...@idosch.org wrote: On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote: [...] I understand how this struct allows you to re-use a lot of code between per-device and per-port traps, but it's mainly

Re: [PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-08 Thread Jiri Pirko
Sun, Sep 06, 2020 at 05:44:28PM CEST, ido...@idosch.org wrote: >On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote: [...] > >I understand how this struct allows you to re-use a lot of code between >per-device and per-port traps, but it's mainly enabled by the fact that >you use the same

Re: [PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-07 Thread Aya Levin
On 9/6/2020 6:44 PM, Ido Schimmel wrote: On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote: There are some cases where we would like to trap dropped packets only for a single port on a device without affecting the others. For that purpose trap_mngr was added to devlink_port and

Re: [PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-06 Thread Ido Schimmel
On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote: > There are some cases where we would like to trap dropped packets only > for a single port on a device without affecting the others. For that > purpose trap_mngr was added to devlink_port and corresponding Trap API > with devlink_port

[PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-02 Thread Aya Levin
There are some cases where we would like to trap dropped packets only for a single port on a device without affecting the others. For that purpose trap_mngr was added to devlink_port and corresponding Trap API with devlink_port were added too. Signed-off-by: Aya Levin ---