Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-23 Thread Arnd Bergmann
On Monday 23 March 2015, Richard Cochran wrote: > > On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: > > Ok, got it. The code looks correct then, though I'd like to see the use > > of 'timespec' pushed out as far as possible. How about changing the > > type for tdr_write() as well

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-23 Thread Richard Cochran
On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: > Ok, got it. The code looks correct then, though I'd like to see the use > of 'timespec' pushed out as far as possible. How about changing the > type for tdr_write() as well here? > > tdr_write() itself should be fine until 2106, as

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-23 Thread Arnd Bergmann
On Monday 23 March 2015, Richard Cochran wrote: On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: Ok, got it. The code looks correct then, though I'd like to see the use of 'timespec' pushed out as far as possible. How about changing the type for tdr_write() as well here?

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-23 Thread Richard Cochran
On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: Ok, got it. The code looks correct then, though I'd like to see the use of 'timespec' pushed out as far as possible. How about changing the type for tdr_write() as well here? tdr_write() itself should be fine until 2106, as it

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-22 Thread Arnd Bergmann
On Sunday 22 March 2015, Richard Cochran wrote: > On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote: > > On Saturday 21 March 2015, Richard Cochran wrote: > > > mutex_lock(>extreg_lock); > > > > > > - err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); > > > + err =

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-22 Thread Richard Cochran
On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote: > On Saturday 21 March 2015, Richard Cochran wrote: > > mutex_lock(>extreg_lock); > > > > - err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); > > + err = tdr_write(1, phydev, , PTP_LOAD_CLK); > > > >

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-22 Thread Richard Cochran
On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote: On Saturday 21 March 2015, Richard Cochran wrote: mutex_lock(clock-extreg_lock); - err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); + err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-22 Thread Arnd Bergmann
On Sunday 22 March 2015, Richard Cochran wrote: On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote: On Saturday 21 March 2015, Richard Cochran wrote: mutex_lock(clock-extreg_lock); - err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); + err = tdr_write(1,

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-21 Thread Arnd Bergmann
On Saturday 21 March 2015, Richard Cochran wrote: > mutex_lock(>extreg_lock); > > - err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); > + err = tdr_write(1, phydev, , PTP_LOAD_CLK); > > mutex_unlock(>extreg_lock); I don't see the change to the tdr_write() function that

[PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-21 Thread Richard Cochran
This device stores the number of seconds in a 32 bit register. So more work is needed on this driver before the year 2038 comes around. Compile tested only. Signed-off-by: Richard Cochran --- drivers/net/phy/dp83640.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

[PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-21 Thread Richard Cochran
This device stores the number of seconds in a 32 bit register. So more work is needed on this driver before the year 2038 comes around. Compile tested only. Signed-off-by: Richard Cochran richardcoch...@gmail.com --- drivers/net/phy/dp83640.c | 12 +++- 1 file changed, 7

Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

2015-03-21 Thread Arnd Bergmann
On Saturday 21 March 2015, Richard Cochran wrote: mutex_lock(clock-extreg_lock); - err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); + err = tdr_write(1, phydev, ts, PTP_LOAD_CLK); mutex_unlock(clock-extreg_lock); I don't see the change to the tdr_write()