Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-08 Thread Jakub Kicinski
On Sat, 9 May 2020 10:56:55 +0800 luobin (L) wrote: > >> - if (!HINIC_IS_VF(nic_dev->hwdev->hwif)) > >> - /* Wait up to 3 sec between port enable to link state */ > >> - msleep(3000); > > Why is this no longer needed? > > ---When phsical port links up, hw will notify this event

Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-08 Thread luobin (L)
Will fix. Thanks for your review. On 2020/5/9 5:36, Jakub Kicinski wrote: On Thu, 7 May 2020 18:21:19 + Luo bin wrote: + return hinic_msg_to_mgmt(&pfhwdev->pf_to_mgmt, HINIC_MOD_COMM, +HINIC_COMM_CMD_HWCTXT_SET, +&hw_ioct

Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-08 Thread Jakub Kicinski
On Thu, 7 May 2020 18:21:19 + Luo bin wrote: > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c > b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c > index 564fb2294a29..bc2f87e6cb5d 100644 > --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c > +++ b/drivers/net/ethernet/h

Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-08 Thread Jakub Kicinski
On Thu, 7 May 2020 18:21:19 + Luo bin wrote: > @@ -899,8 +920,18 @@ int hinic_init_cmdqs(struct hinic_cmdqs *cmdqs, struct > hinic_hwif *hwif, > > hinic_ceq_register_cb(&func_to_io->ceqs, HINIC_CEQ_CMDQ, cmdqs, > cmdq_ceq_handler); > + > + err = hinic_se

Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-08 Thread Jakub Kicinski
On Thu, 7 May 2020 18:21:19 + Luo bin wrote: > + return hinic_msg_to_mgmt(&pfhwdev->pf_to_mgmt, HINIC_MOD_COMM, > + HINIC_COMM_CMD_HWCTXT_SET, > + &hw_ioctxt, sizeof(hw_ioctxt), NULL, > + NULL, HINIC_MGMT

[PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-07 Thread Luo bin
adds ndo_set_vf_rate/ndo_set_vf_spoofchk/ndo_set_vf_link_state to configure netdev of virtual function Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 31 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 35 ++- .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 21 +