Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
On 04/27/2015 01:23 PM, David Miller wrote: From: Murali Karicheri Date: Mon, 27 Apr 2015 13:07:35 -0400 On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called whic

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread David Miller
From: Murali Karicheri Date: Mon, 27 Apr 2015 13:07:35 -0400 > On 04/25/2015 03:48 PM, David Miller wrote: >> From: Murali Karicheri >> Date: Fri, 24 Apr 2015 15:01:41 -0400 >> >>> Currently when interface type is MAC to Phy, netif_carrier_(on/off) >>> is called which is not needed as Phy lib alr

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicheri Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other in

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-25 Thread David Miller
From: Murali Karicheri Date: Fri, 24 Apr 2015 15:01:41 -0400 > Currently when interface type is MAC to Phy, netif_carrier_(on/off) > is called which is not needed as Phy lib already updates the carrier > status to net stack. This is needed only for other interface types > > Signed-off-by: Murali

[PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-24 Thread Murali Karicheri
Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri --- - Fixed comment against initial version - Ok to apply t