Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

2014-07-08 Thread David Miller
From: David Decotigny Date: Tue, 8 Jul 2014 14:50:24 -0700 > In that case, that's what the original code does: dropping this patch 2/2. > > Patch 1/2 "netpoll: fix use after free" is still needed to prevent > panics, though. Please resubmit it then. -- To unsubscribe from this list: send the li

Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

2014-07-08 Thread David Decotigny
In that case, that's what the original code does: dropping this patch 2/2. Patch 1/2 "netpoll: fix use after free" is still needed to prevent panics, though. On Tue, Jul 8, 2014 at 2:17 PM, David Miller wrote: > From: David Decotigny > Date: Tue, 8 Jul 2014 12:35:14 -0700 > >> Thanks for the fe

Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

2014-07-08 Thread David Miller
From: David Decotigny Date: Tue, 8 Jul 2014 12:35:14 -0700 > Thanks for the feedback. This patch results from manual inspection of > the code. I agree my commit description is abusive: in the case of > bonding, I think everything is fine, there should be no ref leak, > cleanup paths seem clean. >

Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

2014-07-08 Thread David Decotigny
Hi, Thanks for the feedback. This patch results from manual inspection of the code. I agree my commit description is abusive: in the case of bonding, I think everything is fine, there should be no ref leak, cleanup paths seem clean. My point was to make things more predictable: ndo_netpoll_cleanu

Re: [PATCH net-next v1 2/2] netpoll: avoid reference leaks

2014-07-07 Thread David Miller
From: David Decotigny Date: Mon, 30 Jun 2014 16:50:10 -0700 > This ensures that the ndo_netpoll_cleanup callback is called for every > device that provides one. Otherwise there is a risk of reference leak > with bonding for example, which depends on this callback to cleanup > the slaves' referenc

[PATCH net-next v1 2/2] netpoll: avoid reference leaks

2014-06-30 Thread David Decotigny
This ensures that the ndo_netpoll_cleanup callback is called for every device that provides one. Otherwise there is a risk of reference leak with bonding for example, which depends on this callback to cleanup the slaves' references to netpoll info. Tested: see patch "netpoll: fix use after free"