Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-24 Thread Oleksij Rempel
On Tue, Jul 14, 2020 at 03:12:40PM +0200, Andrew Lunn wrote: > > OK. So, i'll cover both errata with separate flags? Set flags in the DSA > > driver and apply workarounds in the PHY. ACK? > > Yes. Assume the issues are limited to just the first PHY in this > switch. If there are discrete PHYs

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-14 Thread Andrew Lunn
> OK. So, i'll cover both errata with separate flags? Set flags in the DSA > driver and apply workarounds in the PHY. ACK? Yes. Assume the issues are limited to just the first PHY in this switch. If there are discrete PHYs with the same issue, we can come up with a different way to identify them.

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-14 Thread Oleksij Rempel
On Mon, Jul 13, 2020 at 05:17:19PM +0200, Andrew Lunn wrote: > > > Hi Oleksij > > > > > > Do the PHY register read/writes pass through the DSA driver for the > > > 8873? I was wondering if the switch could intercept reads/writes on > > > port1 for KSZ8081_LMD and return EOPNOTSUPP? That would be

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-13 Thread Andrew Lunn
> > Hi Oleksij > > > > Do the PHY register read/writes pass through the DSA driver for the > > 8873? I was wondering if the switch could intercept reads/writes on > > port1 for KSZ8081_LMD and return EOPNOTSUPP? That would be a more > > robust solution than DT properties, which are going to get

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-13 Thread Oleksij Rempel
On Mon, Jul 13, 2020 at 06:11:30AM +0200, Oleksij Rempel wrote: > On Sat, Jul 11, 2020 at 08:29:12PM +0200, Andrew Lunn wrote: > > On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > > > This patch support for cable test for the ksz886x switches and the > > > ksz8081 PHY. > > > > >

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-12 Thread Oleksij Rempel
On Sat, Jul 11, 2020 at 08:29:12PM +0200, Andrew Lunn wrote: > On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > > This patch support for cable test for the ksz886x switches and the > > ksz8081 PHY. > > > > The patch was tested on a KSZ8873RLL switch with following results: > > >

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-11 Thread Andrew Lunn
On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > This patch support for cable test for the ksz886x switches and the > ksz8081 PHY. > > The patch was tested on a KSZ8873RLL switch with following results: > > - port 1: > - cannot detect any distance > - provides inverted

Re: [PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-11 Thread Andrew Lunn
On Fri, Jul 10, 2020 at 02:08:51PM +0200, Oleksij Rempel wrote: > This patch support for cable test for the ksz886x switches and the > ksz8081 PHY. > > The patch was tested on a KSZ8873RLL switch with following results: > > - port 1: > - cannot detect any distance > - provides inverted

[PATCH net-next v1 5/5] net: phy: micrel: ksz886x/ksz8081: add cabletest support

2020-07-10 Thread Oleksij Rempel
This patch support for cable test for the ksz886x switches and the ksz8081 PHY. The patch was tested on a KSZ8873RLL switch with following results: - port 1: - cannot detect any distance - provides inverted values (Errata: DS8830A: "LinkMD does not work on Port 1",