Re: [PATCH net-next v2] hinic: add firmware update support

2020-07-14 Thread luobin (L)
On 2020/7/15 2:37, Jakub Kicinski wrote: > On Tue, 14 Jul 2020 20:54:33 +0800 Luo bin wrote: >> add support to update firmware by the devlink flashing API >> >> Signed-off-by: Luo bin > > Minor nits below, otherwise I think this looks good. > >> +static int hinic_firmware_update(struct hinic_dev

Re: [PATCH net-next v2] hinic: add firmware update support

2020-07-14 Thread Jakub Kicinski
On Tue, 14 Jul 2020 20:54:33 +0800 Luo bin wrote: > add support to update firmware by the devlink flashing API > > Signed-off-by: Luo bin Minor nits below, otherwise I think this looks good. > +static int hinic_firmware_update(struct hinic_devlink_priv *priv, > + co

[PATCH net-next v2] hinic: add firmware update support

2020-07-14 Thread Luo bin
add support to update firmware by the devlink flashing API Signed-off-by: Luo bin --- V1~V2: create separate devlink priv data structure and remove boot_flag V0~V1: remove the implementation from ethtool to devlink drivers/net/ethernet/huawei/hinic/Makefile| 2 +- drivers/net/ethernet/hua