Re: [PATCH net-next v2] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

2019-08-05 Thread Andrew Lunn
> +static int mv88e6xxx_mdiobus_write_nested(struct mv88e6xxx_chip > *chip, int addr, u32 regnum, u16 val) > +{ > + int err; > + > + BUG_ON(in_interrupt()); > + > + mutex_lock_nested(>bus->mdio_lock, MDIO_MUTEX_NESTED); > + ptp_read_system_prets(chip->ptp_sts); > +

Re: [PATCH net-next v2] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

2019-08-05 Thread Richard Cochran
On Mon, Aug 05, 2019 at 07:12:40PM +0200, Hubert Feurstein wrote: > It got improved, but you still have the unpredictable latencies caused by the > mdio_done-completion (=> wait_for_completion_timeout) in imx_fec. Yes, that is the important point. Please take a look at other mmi_bus.write()

Re: [PATCH net-next v2] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

2019-08-05 Thread Hubert Feurstein
Hi Andrew, Am Mo., 5. Aug. 2019 um 15:58 Uhr schrieb Andrew Lunn : > > On Mon, Aug 05, 2019 at 10:26:42AM +0200, Hubert Feurstein wrote: > > From: Hubert Feurstein > > Hi Hubert > > In your RFC patch, there was some interesting numbers. Can you provide > numbers of just this patch? How much of

Re: [PATCH net-next v2] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

2019-08-05 Thread Andrew Lunn
On Mon, Aug 05, 2019 at 10:26:42AM +0200, Hubert Feurstein wrote: > From: Hubert Feurstein Hi Hubert In your RFC patch, there was some interesting numbers. Can you provide numbers of just this patch? How much of an improvement does it make? Your RFC patch pushed these

[PATCH net-next v2] net: dsa: mv88e6xxx: extend PTP gettime function to read system clock

2019-08-05 Thread Hubert Feurstein
From: Hubert Feurstein This adds support for the PTP_SYS_OFFSET_EXTENDED ioctl. Signed-off-by: Hubert Feurstein --- drivers/net/dsa/mv88e6xxx/ptp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/ptp.c b/drivers/net/dsa/mv88e6xxx/ptp.c