Re: [PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-30 Thread Vladimir Oltean
On Thu, Jul 30, 2020 at 11:40:29AM +0100, Jonathan McDowell wrote: > > > + > > > + for (vid = vlan->vid_begin; vid <= vlan->vid_end && !ret; ++vid) > > > + ret = qca8k_vlan_add(priv, port, vid, !untagged); > > > + > > > + if (ret) > > > + dev_err(priv->dev, "Failed to add VLAN to

Re: [PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-30 Thread Jonathan McDowell
On Tue, Jul 28, 2020 at 07:34:57PM +0300, Vladimir Oltean wrote: > Hi Jonathan, > > On Sun, Jul 26, 2020 at 03:56:11PM +0100, Jonathan McDowell wrote: > > This adds full 802.1q VLAN support to the qca8k, allowing the use of > > vlan_filtering and more complicated bridging setups than allowed by >

Re: [PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-28 Thread Vladimir Oltean
Hi Jonathan, On Sun, Jul 26, 2020 at 03:56:11PM +0100, Jonathan McDowell wrote: > This adds full 802.1q VLAN support to the qca8k, allowing the use of > vlan_filtering and more complicated bridging setups than allowed by > basic port VLAN support. > > Tested with a number of untagged ports with

[PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-26 Thread Jonathan McDowell
This adds full 802.1q VLAN support to the qca8k, allowing the use of vlan_filtering and more complicated bridging setups than allowed by basic port VLAN support. Tested with a number of untagged ports with separate VLANs and then a trunk port with all the VLANs tagged on it. v2: - Return