Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-02-01 Thread Miquel Raynal
Hi Andrew, Andrew Lunn wrote on Fri, 1 Feb 2019 15:08:31 +0100: > On Fri, Feb 01, 2019 at 12:01:19PM +0100, Miquel Raynal wrote: > > Hi Vivien, > > > > Vivien Didelot wrote on Wed, 30 Jan 2019 > > 19:46:08 -0500: > > > > > Hi Miquèl, > > > > > > On Wed, 30 Jan 2019 10:46:06 +0100, Miquel R

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-02-01 Thread Andrew Lunn
On Fri, Feb 01, 2019 at 12:01:19PM +0100, Miquel Raynal wrote: > Hi Vivien, > > Vivien Didelot wrote on Wed, 30 Jan 2019 > 19:46:08 -0500: > > > Hi Miquèl, > > > > On Wed, 30 Jan 2019 10:46:06 +0100, Miquel Raynal > > wrote: > > > > > > > > Today, there is no S2RAM support for switches. Firs

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-02-01 Thread Miquel Raynal
Hi Vivien, Vivien Didelot wrote on Wed, 30 Jan 2019 19:46:08 -0500: > Hi Miquèl, > > On Wed, 30 Jan 2019 10:46:06 +0100, Miquel Raynal > wrote: > > > > > > Today, there is no S2RAM support for switches. First, I proposed to > > > > > add > > > > > suspend/resume callbacks to the mv88e6xxx d

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-30 Thread Vivien Didelot
Hi Miquèl, On Wed, 30 Jan 2019 10:46:06 +0100, Miquel Raynal wrote: > > > > Today, there is no S2RAM support for switches. First, I proposed to add > > > > suspend/resume callbacks to the mv88e6xxx driver - just enough to avoid > > > > crashing the kernel. > > > > > > Then i would suggest th

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-30 Thread Andrew Lunn
> So your proposal is to refuse suspending when using a mv88e6xxx switch. Hi Miquèl That is the first step. It makes the mv88e6xxx suspend compliant, in that it currently does not support suspend. > What about the current situation where suspending is allowed, but all > the configuration gone?

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-30 Thread Miquel Raynal
Hi Vivien & Andrew, Vivien Didelot wrote on Tue, 29 Jan 2019 10:46:13 -0500: > Hi Miquèl, > > On Tue, 29 Jan 2019 15:51:57 +0100, Andrew Lunn wrote: > > > > Today, there is no S2RAM support for switches. First, I proposed to add > > > suspend/resume callbacks to the mv88e6xxx driver - just en

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-29 Thread Vivien Didelot
Hi Miquèl, On Tue, 29 Jan 2019 15:51:57 +0100, Andrew Lunn wrote: > > Today, there is no S2RAM support for switches. First, I proposed to add > > suspend/resume callbacks to the mv88e6xxx driver - just enough to avoid > > crashing the kernel. > > Then i would suggest the mv88e6xxx refuses the s

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-29 Thread Andrew Lunn
On Tue, Jan 29, 2019 at 10:01:17AM +0100, Miquel Raynal wrote: > Hi Andrew, > > Andrew Lunn wrote on Mon, 28 Jan 2019 18:42:46 +0100: > > > On Mon, Jan 28, 2019 at 04:57:49PM +0100, Miquel Raynal wrote: > > > Hi Andrew, > > > > > > Thanks for helping! > > > > > > Andrew Lunn wrote on Mon, 28

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-29 Thread Miquel Raynal
Hi Andrew, Andrew Lunn wrote on Mon, 28 Jan 2019 18:42:46 +0100: > On Mon, Jan 28, 2019 at 04:57:49PM +0100, Miquel Raynal wrote: > > Hi Andrew, > > > > Thanks for helping! > > > > Andrew Lunn wrote on Mon, 28 Jan 2019 15:44:17 +0100: > > > > > > I don't see where VLAN and bridge informati

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-28 Thread Andrew Lunn
On Mon, Jan 28, 2019 at 04:57:49PM +0100, Miquel Raynal wrote: > Hi Andrew, > > Thanks for helping! > > Andrew Lunn wrote on Mon, 28 Jan 2019 15:44:17 +0100: > > > > I don't see where VLAN and bridge information are cached, can you point > > > me to the relevant locations? > > > > Miquèl > >

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-28 Thread Miquel Raynal
Hi Andrew, Thanks for helping! Andrew Lunn wrote on Mon, 28 Jan 2019 15:44:17 +0100: > > I don't see where VLAN and bridge information are cached, can you point > > me to the relevant locations? > > Miquèl > > The bridge should have all that information. You need to ask it to > enumerate th

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-28 Thread Andrew Lunn
> I don't see where VLAN and bridge information are cached, can you point > me to the relevant locations? Miquèl The bridge should have all that information. You need to ask it to enumerate the current configuration and replay it to the switch. There might be something in the Mellanox driver you

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-28 Thread Miquel Raynal
Hi Florian, Florian Fainelli wrote on Fri, 25 Jan 2019 10:37:38 -0800: > Hi Miquel, > > On 1/25/19 1:55 AM, Miquel Raynal wrote: > > The user might apply a specific switch configuration, with specific > > forwarding rules, VLAN, bridges, etc. > > > > During suspend to RAM the switch power will

Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-25 Thread Florian Fainelli
Hi Miquel, On 1/25/19 1:55 AM, Miquel Raynal wrote: > The user might apply a specific switch configuration, with specific > forwarding rules, VLAN, bridges, etc. > > During suspend to RAM the switch power will be turned off and the > switch will lost its configuration. In an attempt to bring S2RA

[PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules

2019-01-25 Thread Miquel Raynal
The user might apply a specific switch configuration, with specific forwarding rules, VLAN, bridges, etc. During suspend to RAM the switch power will be turned off and the switch will lost its configuration. In an attempt to bring S2RAM support to the mv88e6xxx DSA, let's first save these rules in