Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-22 Thread Alex Elder
On 3/22/21 5:56 PM, Andrew Lunn wrote: The solution is to create a user space tool inside the drivers/net/ipa directory that will link with the kernel source files and will perform all the basic one-time checks I want to make. Hi Alex Have you found any other driver doing this? Where do they

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-22 Thread Andrew Lunn
> The solution is to create a user space tool inside the > drivers/net/ipa directory that will link with the kernel > source files and will perform all the basic one-time checks > I want to make. Hi Alex Have you found any other driver doing this? Where do they keep there code? Could this be a

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-22 Thread Alex Elder
On 3/22/21 9:17 AM, Leon Romanovsky wrote: We are not talking about putting this tool in upstream repo, right? If yes, please get buy-in from David/Jakub first. I'll make the user space sanity check tool either way. It would be nice to have it upstream, the checks continue to be made as the ke

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-22 Thread Leon Romanovsky
On Mon, Mar 22, 2021 at 08:17:59AM -0500, Alex Elder wrote: > On 3/22/21 1:40 AM, Leon Romanovsky wrote: > > > I'd like to suggest a plan so I can begin to make progress, > > > but do so in a way you/others think is satisfactory. > > > - I would first like to fix the existing bugs, namely that > >

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-22 Thread Alex Elder
On 3/22/21 1:40 AM, Leon Romanovsky wrote: I'd like to suggest a plan so I can begin to make progress, but do so in a way you/others think is satisfactory. - I would first like to fix the existing bugs, namely that if IPA_VALIDATION is defined there are build errors, and that IPA_VALIDATION

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-21 Thread Leon Romanovsky
On Sun, Mar 21, 2021 at 12:19:02PM -0500, Alex Elder wrote: > On 3/21/21 8:49 AM, Leon Romanovsky wrote: > > On Sun, Mar 21, 2021 at 08:21:24AM -0500, Alex Elder wrote: > >> On 3/21/21 3:21 AM, Leon Romanovsky wrote: > >>> On Sat, Mar 20, 2021 at 09:17:29AM -0500, Alex Elder wrote: > There are

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-21 Thread Alex Elder
On 3/21/21 8:49 AM, Leon Romanovsky wrote: > On Sun, Mar 21, 2021 at 08:21:24AM -0500, Alex Elder wrote: >> On 3/21/21 3:21 AM, Leon Romanovsky wrote: >>> On Sat, Mar 20, 2021 at 09:17:29AM -0500, Alex Elder wrote: There are blocks of IPA code that sanity-check various values, at compile

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-21 Thread Leon Romanovsky
On Sun, Mar 21, 2021 at 08:21:24AM -0500, Alex Elder wrote: > On 3/21/21 3:21 AM, Leon Romanovsky wrote: > > On Sat, Mar 20, 2021 at 09:17:29AM -0500, Alex Elder wrote: > > > There are blocks of IPA code that sanity-check various values, at > > > compile time where possible. Most of these checks c

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-21 Thread Alex Elder
On 3/21/21 3:21 AM, Leon Romanovsky wrote: On Sat, Mar 20, 2021 at 09:17:29AM -0500, Alex Elder wrote: There are blocks of IPA code that sanity-check various values, at compile time where possible. Most of these checks can be done once during development but skipped for normal operation. These

Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-21 Thread Leon Romanovsky
On Sat, Mar 20, 2021 at 09:17:29AM -0500, Alex Elder wrote: > There are blocks of IPA code that sanity-check various values, at > compile time where possible. Most of these checks can be done once > during development but skipped for normal operation. These checks > permit the driver to make cert

[PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-20 Thread Alex Elder
There are blocks of IPA code that sanity-check various values, at compile time where possible. Most of these checks can be done once during development but skipped for normal operation. These checks permit the driver to make certain assumptions, thereby avoiding the need for runtime error checkin