RE: [PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-13 Thread Bryan.Whitehead
> Will do. Are you planning to hold off your tests until v3? It shouldn't take > too > long. Sure, we will wait for v3

Re: [PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-12 Thread Sven Van Asbroeck
Hi Bryan, On Fri, Feb 12, 2021 at 3:45 PM wrote: > > According to the document I have, FRAME_LENGTH is only valid when LS bit is > set, and reserved otherwise. > Therefore, I'm not sure you can rely on it being zero when LS is not set, > even if your experiments say it is. > Future chip

RE: [PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-12 Thread Bryan.Whitehead
Hi Sven, see below. > + if (buffer_info->dma_ptr) { > + /* unmap from dma */ > + packet_length = RX_DESC_DATA0_FRAME_LENGTH_GET_ > + (le32_to_cpu(descriptor->data0)); > + if (packet_length == 0 || > +

[PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

2021-02-11 Thread Sven Van Asbroeck
From: Sven Van Asbroeck On cpu architectures w/o dma cache snooping, dma_unmap() is a is a very expensive operation, because its resulting sync needs to invalidate cpu caches. Increase efficiency/performance by syncing only those sections of the lan743x's rx ring buffers that are actually in