Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread David Miller
From: Andrew Lunn Date: Fri, 17 Feb 2017 23:36:51 +0100 > Please take your time to do this right. Lots of small patches, which > are obviously correct. Agreed.

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread David Miller
From: Andrew Lunn Date: Fri, 17 Feb 2017 23:36:51 +0100 > Please take your time to do this right. Lots of small patches, which > are obviously correct. Agreed.

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
> Note that we are very close from 4.10, so unless there is a major issue > in the patchset, I'd prefer not to respin new versions. I'd gladly send > cosmetics fixup later though. I'm waiting for this patchset to land in > net-next to send the second one ready for cross-chip bridging in DSA. I

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
> Note that we are very close from 4.10, so unless there is a major issue > in the patchset, I'd prefer not to respin new versions. I'd gladly send > cosmetics fixup later though. I'm waiting for this patchset to land in > net-next to send the second one ready for cross-chip bridging in DSA. I

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This seems to be more than renaming a few functions. There looks to be > real changes here. I think these changes should be split out into a > separate patch with an explanation what is being changed. Keep this > patch for plain renames. > > It

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This seems to be more than renaming a few functions. There looks to be > real changes here. I think these changes should be split out into a > separate patch with an explanation what is being changed. Keep this > patch for plain renames. > > It would also be

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:27AM -0500, Vivien Didelot wrote: > Move the Global (1) ATU related code in its own file, and export the > necessary primitives. > > Use that opportunity to provide a cleaner API for the ATU, by renaming a > few underscore prefixed functions, and members of the >

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:27AM -0500, Vivien Didelot wrote: > Move the Global (1) ATU related code in its own file, and export the > necessary primitives. > > Use that opportunity to provide a cleaner API for the ATU, by renaming a > few underscore prefixed functions, and members of the >

[PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Move the Global (1) ATU related code in its own file, and export the necessary primitives. Use that opportunity to provide a cleaner API for the ATU, by renaming a few underscore prefixed functions, and members of the mv88e6xxx_atu_entry structures. Signed-off-by: Vivien Didelot

[PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Move the Global (1) ATU related code in its own file, and export the necessary primitives. Use that opportunity to provide a cleaner API for the ATU, by renaming a few underscore prefixed functions, and members of the mv88e6xxx_atu_entry structures. Signed-off-by: Vivien Didelot ---