Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-05 Thread Antoine Tenart
Hi Russell, On Mon, Mar 04, 2019 at 04:10:47PM +, Russell King - ARM Linux admin wrote: > On Mon, Mar 04, 2019 at 11:47:00AM +0100, Antoine Tenart wrote: > > > > I agree having a per-driver behaviour is not something we want. As I > > understand it, there is no behaviour enforced currently re

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-04 Thread Russell King - ARM Linux admin
On Mon, Mar 04, 2019 at 11:47:00AM +0100, Antoine Tenart wrote: > Hi Florian, > > I agree having a per-driver behaviour is not something we want. As I > understand it, there is no behaviour enforced currently regarding this > matter. I agree both cases have their pros and cons: > - It's weird to h

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-04 Thread Antoine Tenart
Hi Florian, On Fri, Mar 01, 2019 at 07:08:56PM -0800, Florian Fainelli wrote: > On 3/1/2019 7:07 AM, Antoine Tenart wrote: > > On Fri, Mar 01, 2019 at 03:19:53PM +0100, Andrew Lunn wrote: > >> On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote: > >>> When the Marvell 10G PHYs are set o

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-01 Thread Florian Fainelli
On 3/1/2019 7:07 AM, Antoine Tenart wrote: > Hi Andrew, > > On Fri, Mar 01, 2019 at 03:19:53PM +0100, Andrew Lunn wrote: >> On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote: >>> When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set >>> depending on an hardware conf

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-01 Thread Antoine Tenart
Hi Andrew, On Fri, Mar 01, 2019 at 03:19:53PM +0100, Andrew Lunn wrote: > On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote: > > When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set > > depending on an hardware configuration choice. We also do not know what > > is the

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-01 Thread Andrew Lunn
On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote: > When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set > depending on an hardware configuration choice. We also do not know what > is the PHY state at boot time. Hence, set the PHY in low power by > default when this d

[PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-01 Thread Antoine Tenart
When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set depending on an hardware configuration choice. We also do not know what is the PHY state at boot time. Hence, set the PHY in low power by default when this driver probes. Signed-off-by: Antoine Tenart --- drivers/net/phy/marve