Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote: > The 6390 family of Marvell chips uses 5 bits to describe the ToPort and > FromPort values of PortVec in the ATU Move operation, while older > switches use 0xf. Hi Vivien Since you say 5 bits for 6390, it would be better to say 4 bi

[PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-17 Thread Vivien Didelot
The 6390 family of Marvell chips uses 5 bits to describe the ToPort and FromPort values of PortVec in the ATU Move operation, while older switches use 0xf. Add an atu_move_port_mask member in the info structure to describe that. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c