Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-26 Thread Dan Murphy
Andrew On 5/23/20 5:07 PM, Andrew Lunn wrote: Any why is your PHY special, in that is does care about out of range delays, when others using new the new core helper don't? We are not rounding to nearest here.  Basically the helper works to find the best match If the delay passed in is less tha

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Andrew Lunn
> > Any why is your PHY special, in that is does care about out of range > > delays, when others using new the new core helper don't? > > We are not rounding to nearest here.  Basically the helper works to find the > best match > > If the delay passed in is less than or equal to the smallest dela

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Dan Murphy
Andrew On 5/23/20 10:09 AM, Andrew Lunn wrote: + dp83869->tx_id_delay = DP83869_RGMII_CLK_DELAY_INV; + ret = of_property_read_u32(of_node, "tx-internal-delay-ps", + &dp83869->tx_id_delay); + if (!ret && dp83869->tx_id_delay > dp83869_internal_de

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Andrew Lunn
> > > + dp83869->tx_id_delay = DP83869_RGMII_CLK_DELAY_INV; > > > + ret = of_property_read_u32(of_node, "tx-internal-delay-ps", > > > +&dp83869->tx_id_delay); > > > + if (!ret && dp83869->tx_id_delay > dp83869_internal_delay[delay_size]) { > > > + phydev_err(phyd

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-22 Thread Dan Murphy
Florian On 5/22/20 11:13 AM, Florian Fainelli wrote: On 5/22/2020 5:25 AM, Dan Murphy wrote: Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 101 ++ 1 file changed, 101 insertions(+) diff

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-22 Thread Florian Fainelli
On 5/22/2020 5:25 AM, Dan Murphy wrote: > Add RGMII internal delay configuration for Rx and Tx. > > Signed-off-by: Dan Murphy > --- > drivers/net/phy/dp83869.c | 101 ++ > 1 file changed, 101 insertions(+) > > diff --git a/drivers/net/phy/dp83869.c b/drive

[PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-22 Thread Dan Murphy
Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 101 ++ 1 file changed, 101 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index cfb22a21a2e6..a9008d32e2b6 10064

[PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-20 Thread Dan Murphy
Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 84 +++ 1 file changed, 84 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index cfb22a21a2e6..f08008050177 100644