Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-03 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 6:55 PM David Miller wrote: > > From: Jarod Wilson > Date: Fri, 2 Oct 2020 16:12:49 -0400 > > > The documentation was updated to point to the new names, but the old > > ones still exist across the board, there should be no userspace > > breakage here. (My lnst bonding tests

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread David Miller
From: Jarod Wilson Date: Fri, 2 Oct 2020 16:12:49 -0400 > The documentation was updated to point to the new names, but the old > ones still exist across the board, there should be no userspace > breakage here. (My lnst bonding tests actually fall flat currently > if the old names are gone). The

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Andrew Lunn
On Fri, Oct 02, 2020 at 04:17:34PM -0400, Jarod Wilson wrote: > On Fri, Oct 2, 2020 at 2:09 PM Andrew Lunn wrote: > > > > On Fri, Oct 02, 2020 at 01:40:00PM -0400, Jarod Wilson wrote: > > > Point users to the new interface names instead of the old ones, where > > > appropriate. Userspace bits refe

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 2:09 PM Andrew Lunn wrote: > > On Fri, Oct 02, 2020 at 01:40:00PM -0400, Jarod Wilson wrote: > > Point users to the new interface names instead of the old ones, where > > appropriate. Userspace bits referenced still include use of master/slave, > > but those can't be altered

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
On Fri, Oct 2, 2020 at 3:11 PM Stephen Hemminger wrote: > > On Fri, 2 Oct 2020 13:40:00 -0400 > Jarod Wilson wrote: > > > @@ -265,7 +265,7 @@ ad_user_port_key > > This parameter has effect only in 802.3ad mode and is available > > through > > SysFs interface. > > > > -all_slaves_act

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Stephen Hemminger
On Fri, 2 Oct 2020 13:40:00 -0400 Jarod Wilson wrote: > @@ -265,7 +265,7 @@ ad_user_port_key > This parameter has effect only in 802.3ad mode and is available through > SysFs interface. > > -all_slaves_active > +all_ports_active You can change internal variable names, comments, an

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Andrew Lunn
On Fri, Oct 02, 2020 at 01:40:00PM -0400, Jarod Wilson wrote: > Point users to the new interface names instead of the old ones, where > appropriate. Userspace bits referenced still include use of master/slave, > but those can't be altered until userspace changes too, ideally after > these changes p

[PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Jarod Wilson
Point users to the new interface names instead of the old ones, where appropriate. Userspace bits referenced still include use of master/slave, but those can't be altered until userspace changes too, ideally after these changes propagate to the community at large. Cc: Jay Vosburgh Cc: Veaceslav F