Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-18 Thread Martin Schiller
On 2020-11-18 14:46, Xie He wrote: On Wed, Nov 18, 2020 at 5:03 AM Xie He wrote: On Wed, Nov 18, 2020 at 12:49 AM Martin Schiller wrote: > > I also have a patch here that implements an "on demand" link feature, > which we used for ISDN dialing connections. > As ISDN is de facto dead, this

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-18 Thread Xie He
On Wed, Nov 18, 2020 at 5:03 AM Xie He wrote: > > On Wed, Nov 18, 2020 at 12:49 AM Martin Schiller wrote: > > > > I also have a patch here that implements an "on demand" link feature, > > which we used for ISDN dialing connections. > > As ISDN is de facto dead, this is not relevant anymore. But

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-18 Thread Xie He
On Wed, Nov 18, 2020 at 12:49 AM Martin Schiller wrote: > > Ah, ok. Now I see what you mean. > Yes, we should check the lapb->mode in lapb_connect_request(). ... > I also have a patch here that implements an "on demand" link feature, > which we used for ISDN dialing connections. > As ISDN is de

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-18 Thread Martin Schiller
On 2020-11-17 19:28, Xie He wrote: On Tue, Nov 17, 2020 at 5:26 AM Martin Schiller wrote: On 2020-11-17 12:32, Xie He wrote: > > I think for a DCE, it doesn't need to initiate the L2 > connection on device-up. It just needs to wait for a connection to > come. But L3 seems to be still

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-17 Thread Xie He
On Tue, Nov 17, 2020 at 5:26 AM Martin Schiller wrote: > > On 2020-11-17 12:32, Xie He wrote: > > > > I think for a DCE, it doesn't need to initiate the L2 > > connection on device-up. It just needs to wait for a connection to > > come. But L3 seems to be still instructing it to initiate the L2 >

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-17 Thread Martin Schiller
On 2020-11-17 12:32, Xie He wrote: On Tue, Nov 17, 2020 at 1:53 AM Martin Schiller wrote: On 2020-11-16 21:16, Xie He wrote: > Do you mean we will now automatically establish LAPB connections > without upper layers instructing us to do so? Yes, as soon as the physical link is established,

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-17 Thread Xie He
On Tue, Nov 17, 2020 at 1:53 AM Martin Schiller wrote: > > On 2020-11-16 21:16, Xie He wrote: > > Do you mean we will now automatically establish LAPB connections > > without upper layers instructing us to do so? > > Yes, as soon as the physical link is established, the L2 and also the > L3 layer

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-17 Thread Martin Schiller
On 2020-11-16 21:16, Xie He wrote: Do you mean we will now automatically establish LAPB connections without upper layers instructing us to do so? Yes, as soon as the physical link is established, the L2 and also the L3 layer (restart handshake) is established. In this context I also noticed

Re: [PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-16 Thread Xie He
On Mon, Nov 16, 2020 at 6:01 AM Martin Schiller wrote: > > This makes it possible to handle carrier loss and detection. > In case of Carrier Loss, layer 2 is terminated > In case of Carrier Detection, we start timer t1 on a DCE interface, > and on a DTE interface we change to state LAPB_STATE_1

[PATCH net-next v2 5/6] net/lapb: support netdev events

2020-11-16 Thread Martin Schiller
This makes it possible to handle carrier loss and detection. In case of Carrier Loss, layer 2 is terminated In case of Carrier Detection, we start timer t1 on a DCE interface, and on a DTE interface we change to state LAPB_STATE_1 and start sending SABM(E). Signed-off-by: Martin Schiller ---