Re: [PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit

2017-05-31 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > On 05/30/2017 11:33 AM, Vivien Didelot wrote: >> The taggers are currently responsible to free the original SKB if they >> made a copy of it, or in case of error. >> >> This patch simplifies this by freeing the original SKB in the >>

Re: [PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit

2017-05-31 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > On 05/30/2017 11:33 AM, Vivien Didelot wrote: >> The taggers are currently responsible to free the original SKB if they >> made a copy of it, or in case of error. >> >> This patch simplifies this by freeing the original SKB in the >> dsa_slave_xmit

Re: [PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit

2017-05-30 Thread Florian Fainelli
On 05/30/2017 11:33 AM, Vivien Didelot wrote: > The taggers are currently responsible to free the original SKB if they > made a copy of it, or in case of error. > > This patch simplifies this by freeing the original SKB in the > dsa_slave_xmit caller, but only if an error (NULL) is returned. Is

Re: [PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit

2017-05-30 Thread Florian Fainelli
On 05/30/2017 11:33 AM, Vivien Didelot wrote: > The taggers are currently responsible to free the original SKB if they > made a copy of it, or in case of error. > > This patch simplifies this by freeing the original SKB in the > dsa_slave_xmit caller, but only if an error (NULL) is returned. Is

[PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit

2017-05-30 Thread Vivien Didelot
The taggers are currently responsible to free the original SKB if they made a copy of it, or in case of error. This patch simplifies this by freeing the original SKB in the dsa_slave_xmit caller, but only if an error (NULL) is returned. It is still the responsibility of the tagger to free the

[PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit

2017-05-30 Thread Vivien Didelot
The taggers are currently responsible to free the original SKB if they made a copy of it, or in case of error. This patch simplifies this by freeing the original SKB in the dsa_slave_xmit caller, but only if an error (NULL) is returned. It is still the responsibility of the tagger to free the