Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-07-10 Thread Alexandre Belloni
On 11/07/2020 00:54:53+0200, Andrew Lunn wrote: > On Sat, Jul 11, 2020 at 12:36:10AM +0200, Alexandre Belloni wrote: > > Hi Oleksij, > > > > This patch breaks Ethernet on the sama5d3 Xplained and I have not been > > able to unbreak it. > > Hi Alexandre > > macb0:

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-07-10 Thread Andrew Lunn
On Sat, Jul 11, 2020 at 12:36:10AM +0200, Alexandre Belloni wrote: > Hi Oleksij, > > This patch breaks Ethernet on the sama5d3 Xplained and I have not been > able to unbreak it. Hi Alexandre macb0: ethernet@f0028000 { phy-mode = "rgmii";

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-07-10 Thread Alexandre Belloni
Hi Oleksij, This patch breaks Ethernet on the sama5d3 Xplained and I have not been able to unbreak it. Note tat If you want to test, networking has been further broken in v5.8-rc1 but should be properly working in v5.8-rc4 after reverting this patch. On 22/04/2020 09:21:37+0200, Oleksij Rempel

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-29 Thread Geert Uytterhoeven
Hi Andrew, On Thu, May 28, 2020 at 6:08 PM Andrew Lunn wrote: > On Thu, May 28, 2020 at 03:10:06PM +0200, Geert Uytterhoeven wrote: > > On Wed, May 27, 2020 at 10:52 PM Andrew Lunn wrote: > > > > You may wonder what's the difference between 3 and 4? It's not just the > > > > PHY driver that

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Oleksij Rempel
On Thu, May 28, 2020 at 06:08:39PM +0200, Andrew Lunn wrote: > On Thu, May 28, 2020 at 03:10:06PM +0200, Geert Uytterhoeven wrote: > > Hi Andrew, > > > > On Wed, May 27, 2020 at 10:52 PM Andrew Lunn wrote: > > > > You may wonder what's the difference between 3 and 4? It's not just the > > > >

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Florian Fainelli
On 5/28/2020 5:51 AM, Geert Uytterhoeven wrote: > Hi Philippe, > > On Thu, May 28, 2020 at 10:20 AM Philippe Schenker > wrote: >> On Wed, 2020-05-27 at 21:11 +0200, Geert Uytterhoeven wrote: >>> On Wed, Apr 29, 2020 at 11:26 AM Oleksij Rempel < >>> o.rem...@pengutronix.de> wrote: On Wed,

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Andrew Lunn
On Thu, May 28, 2020 at 03:10:06PM +0200, Geert Uytterhoeven wrote: > Hi Andrew, > > On Wed, May 27, 2020 at 10:52 PM Andrew Lunn wrote: > > > You may wonder what's the difference between 3 and 4? It's not just the > > > PHY driver that looks at phy-mode! > > >

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Geert Uytterhoeven
Hi Andrew, On Wed, May 27, 2020 at 10:52 PM Andrew Lunn wrote: > > You may wonder what's the difference between 3 and 4? It's not just the > > PHY driver that looks at phy-mode! > > drivers/net/ethernet/renesas/ravb_main.c:ravb_set_delay_mode() also > > does, and configures an additional TX

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Geert Uytterhoeven
Hi Philippe, On Thu, May 28, 2020 at 10:20 AM Philippe Schenker wrote: > On Wed, 2020-05-27 at 21:11 +0200, Geert Uytterhoeven wrote: > > On Wed, Apr 29, 2020 at 11:26 AM Oleksij Rempel < > > o.rem...@pengutronix.de> wrote: > > > On Wed, Apr 29, 2020 at 10:45:35AM +0200, Geert Uytterhoeven

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-28 Thread Philippe Schenker
On Wed, 2020-05-27 at 21:11 +0200, Geert Uytterhoeven wrote: > Hi Oleksij, > > On Wed, Apr 29, 2020 at 11:26 AM Oleksij Rempel < > o.rem...@pengutronix.de> wrote: > > On Wed, Apr 29, 2020 at 10:45:35AM +0200, Geert Uytterhoeven wrote: > > > On Tue, Apr 28, 2020 at 6:16 PM Philippe Schenker > > >

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-27 Thread Andrew Lunn
> You may wonder what's the difference between 3 and 4? It's not just the > PHY driver that looks at phy-mode! > drivers/net/ethernet/renesas/ravb_main.c:ravb_set_delay_mode() also > does, and configures an additional TX clock delay of 1.8 ns if TXID is > enabled. Hi Geert That sounds like a MAC

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-27 Thread Geert Uytterhoeven
Hi Oleksij, On Wed, Apr 29, 2020 at 11:26 AM Oleksij Rempel wrote: > On Wed, Apr 29, 2020 at 10:45:35AM +0200, Geert Uytterhoeven wrote: > > On Tue, Apr 28, 2020 at 6:16 PM Philippe Schenker > > wrote: > > > On Tue, 2020-04-28 at 17:47 +0200, Andrew Lunn wrote: > > > > On Tue, Apr 28, 2020 at

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-05 Thread Oleksij Rempel
Hi Grygorii, On Tue, May 05, 2020 at 09:26:46PM +0300, Grygorii Strashko wrote: > > > On 22/04/2020 10:21, Oleksij Rempel wrote: > > Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, > > rgmii-rxid. > > > > This PHY has an internal RX delay of 1.2ns and no delay for TX. > > >

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-05 Thread Grygorii Strashko
On 22/04/2020 10:21, Oleksij Rempel wrote: Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, rgmii-rxid. This PHY has an internal RX delay of 1.2ns and no delay for TX. The pad skew registers allow to set the total TX delay to max 1.38ns and the total RX delay to max of

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-04-29 Thread Philippe Schenker
On Wed, 2020-04-29 at 10:45 +0200, Geert Uytterhoeven wrote: > Hi Philippe, > > On Tue, Apr 28, 2020 at 6:16 PM Philippe Schenker > wrote: > > On Tue, 2020-04-28 at 17:47 +0200, Andrew Lunn wrote: > > > On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven > > > wrote: > > > > This

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-04-29 Thread Oleksij Rempel
Hi Geert, On Wed, Apr 29, 2020 at 10:45:35AM +0200, Geert Uytterhoeven wrote: > Hi Philippe, > > On Tue, Apr 28, 2020 at 6:16 PM Philippe Schenker > wrote: > > On Tue, 2020-04-28 at 17:47 +0200, Andrew Lunn wrote: > > > On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven wrote: > > > >

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-04-29 Thread Geert Uytterhoeven
Hi Philippe, On Tue, Apr 28, 2020 at 6:16 PM Philippe Schenker wrote: > On Tue, 2020-04-28 at 17:47 +0200, Andrew Lunn wrote: > > On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven wrote: > > > This triggers on Renesas Salvator-X(S): > > > > > > Micrel KSZ9031 Gigabit PHY

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-04-28 Thread Philippe Schenker
On Tue, 2020-04-28 at 17:47 +0200, Andrew Lunn wrote: > On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven wrote: > > This triggers on Renesas Salvator-X(S): > > > > Micrel KSZ9031 Gigabit PHY e680.ethernet-:00: > > *-skew-ps values should be used only with phy-mode =

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-04-28 Thread Andrew Lunn
On Tue, Apr 28, 2020 at 05:28:30PM +0200, Geert Uytterhoeven wrote: > This triggers on Renesas Salvator-X(S): > > Micrel KSZ9031 Gigabit PHY e680.ethernet-:00: > *-skew-ps values should be used only with phy-mode = "rgmii" > > which uses: > > phy-mode = "rgmii-txid"; >

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-04-28 Thread Geert Uytterhoeven
Hi Oleksij, On Wed, Apr 22, 2020 at 9:24 AM Oleksij Rempel wrote: > Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, rgmii-rxid. > > This PHY has an internal RX delay of 1.2ns and no delay for TX. > > The pad skew registers allow to set the total TX delay to max 1.38ns and > the