RE: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-16 Thread hayeswang
From: Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Saturday, March 15, 2014 7:43 AM [...] > > Besides, I don't wish to modify the setting by ethtool when re-loading > > the driver or rebooting every time. > > Why ? > > The recipe is different but there isn't much setup difference > be

RE: [PATCH net-next v3 1/2]r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-16 Thread hayeswang
From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, March 15, 2014 2:43 AM [...] > > Besides, I don't wish to modify the setting by ethtool when re-loading > > the driver or rebooting every time. > > You have code to reset the driver, you can do it when the user asks > for the sett

Re: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-14 Thread Francois Romieu
hayeswang : [...] > Besides, I don't wish to modify the setting by ethtool when re-loading > the driver or rebooting every time. Why ? The recipe is different but there isn't much setup difference between a module param and an ethtool command that is run through udev. The latter is more versatil

Re: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-14 Thread David Miller
From: hayeswang Date: Fri, 14 Mar 2014 15:24:50 +0800 > Besides, I don't wish to modify the setting by ethtool when re-loading > the driver or rebooting every time. You have code to reset the driver, you can do it when the user asks for the setting to be changed via ethtool. I do not see this a

RE: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-14 Thread hayeswang
From: David Miller [mailto:da...@davemloft.net] Sent: Friday, March 14, 2014 12:08 PM [...] > >> And I fundamentally disagree with this being a Kconfig parameter. > >> > >> Make it run-time calculated _or_ settable via ethtool. > > > > Excuse me. How should I make it run-time calculated withou

Re: [PATCH net-next v3 1/2] r8152: addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-13 Thread David Miller
From: hayeswang Date: Fri, 14 Mar 2014 10:37:21 +0800 > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, March 14, 2014 1:22 AM > [...] >> And I fundamentally disagree with this being a Kconfig parameter. >> >> Make it run-time calculated _or_ settable via ethtool. > > Excuse

RE: [PATCH net-next v3 1/2] r8152: addRTL8152_EARLY_AGG_TIMEOUT_SUPER

2014-03-13 Thread hayeswang
From: David Miller [mailto:da...@davemloft.net] Sent: Friday, March 14, 2014 1:22 AM [...] > And I fundamentally disagree with this being a Kconfig parameter. > > Make it run-time calculated _or_ settable via ethtool. Excuse me. How should I make it run-time calculated without a Kconfig parame