Re: [PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

On Thu, Oct 29, 2020 at 10:00 AM Willem de Bruijn wrote: > > This does change rx_dropped count on errors. Not sure how important > that is. But perhaps good to call out in the commit explicitly if it's > intentional. Yes, this is intentional, because I think we need to count it as a "drop" whenev

Re: [PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

On Wed, Oct 28, 2020 at 6:01 PM Xie He wrote: > > When the fr_rx function drops a received frame (because the protocol type > is not supported, or because the PVC virtual device that corresponds to > the DLCI number and the protocol type doesn't exist), the function frees > the skb and returns. >

[PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated sev