Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread Zoltan Kiss
On 09/01/14 15:30, Wei Liu wrote: On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: v3: - fix comment in xenvif_tx_dealloc_action() - call unmap hypercall directly instead of gnttab_unmap_refs(), which does unnecessary m2p_override. Also remove pages_to_[un]map members Is it wort

Re: [Xen-devel] [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread David Vrabel
On 09/01/14 18:09, Stefano Stabellini wrote: > > I agree, but I think that we have different views on the use case. > To me the m2p_override use case is "everywhere an mfn_to_pfn translation > is required", that unfortunately is potentially everywhere at this time. mfn_to_pfn() cannot be made to

Re: [Xen-devel] [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread Stefano Stabellini
On Thu, 9 Jan 2014, David Vrabel wrote: > On 09/01/14 17:28, Stefano Stabellini wrote: > > On Thu, 9 Jan 2014, David Vrabel wrote: > >> On 09/01/14 15:30, Wei Liu wrote: > >>> On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: > This patch contains the new definitions necessary for g

Re: [Xen-devel] [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread David Vrabel
On 09/01/14 17:28, Stefano Stabellini wrote: > On Thu, 9 Jan 2014, David Vrabel wrote: >> On 09/01/14 15:30, Wei Liu wrote: >>> On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: This patch contains the new definitions necessary for grant mapping. v2: - move unmapping

Re: [Xen-devel] [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread Stefano Stabellini
On Thu, 9 Jan 2014, David Vrabel wrote: > On 09/01/14 15:30, Wei Liu wrote: > > On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: > >> This patch contains the new definitions necessary for grant mapping. > >> > >> v2: > >> - move unmapping to separate thread. The NAPI instance has to be

Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread Roger Pau Monné
On 09/01/14 16:30, Wei Liu wrote: > On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: >> This patch contains the new definitions necessary for grant mapping. >> >> v2: >> - move unmapping to separate thread. The NAPI instance has to be scheduled >> even from thread context, which can c

Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread David Vrabel
On 09/01/14 15:30, Wei Liu wrote: > On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: >> This patch contains the new definitions necessary for grant mapping. >> >> v2: >> - move unmapping to separate thread. The NAPI instance has to be scheduled >> even from thread context, which can c

Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-09 Thread Wei Liu
On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote: > This patch contains the new definitions necessary for grant mapping. > > v2: > - move unmapping to separate thread. The NAPI instance has to be scheduled > even from thread context, which can cause huge delays > - that causes unfortu

Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-08 Thread Zoltan Kiss
On 08/01/14 01:29, David Miller wrote: +static inline int tx_dealloc_work_todo(struct xenvif *vif) Make this return bool. Done, also in the last patch. + wait_event_interruptible(vif->dealloc_wq, + tx_dealloc_work_todo(vif) || +

Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-07 Thread David Miller
From: Zoltan Kiss Date: Wed, 8 Jan 2014 00:10:10 + > This patch contains the new definitions necessary for grant mapping. > > v2: > - move unmapping to separate thread. The NAPI instance has to be scheduled > even from thread context, which can cause huge delays > - that causes unfortunate

[PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

2014-01-07 Thread Zoltan Kiss
This patch contains the new definitions necessary for grant mapping. v2: - move unmapping to separate thread. The NAPI instance has to be scheduled even from thread context, which can cause huge delays - that causes unfortunately bigger struct xenvif - store grant handle after checking validity