Andrew
On 5/27/20 8:12 AM, Andrew Lunn wrote:
If the dt defines rgmii-rx/tx-id then these values are required not
optional. That was the discussion on the binding.
How many times do i need to say it. They are optional. If not
specified, default to 2ns.
OK. I guess then the DP83867 driver is
> If the dt defines rgmii-rx/tx-id then these values are required not
> optional. That was the discussion on the binding.
How many times do i need to say it. They are optional. If not
specified, default to 2ns.
> > > + ret = of_property_read_u32(of_node, "tx-internal-delay-ps",
> > > +
Andrew
On 5/26/20 7:52 PM, Andrew Lunn wrote:
@@ -218,6 +224,7 @@ static int dp83869_of_init(struct phy_device *phydev)
ret = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_STRAP_STS1);
if (ret < 0)
return ret;
+
if (ret & DP
> +static int dp83869_internal_delay[] = {250, 500, 750, 1000, 1250, 1500, 1750,
> +2000, 2250, 2500, 2750, 3000, 3250,
> +3500, 3750, 4000};
> +
You should make this const. Otherwise it takes up twice the space.
Andrew
> @@ -218,6 +224,7 @@ static int dp83869_of_init(struct phy_device *phydev)
> ret = phy_read_mmd(phydev, DP83869_DEVADDR, DP83869_STRAP_STS1);
> if (ret < 0)
> return ret;
> +
> if (ret & DP83869_STRAP_MIRROR_ENABLED)
>
Add RGMII internal delay configuration for Rx and Tx.
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83869.c | 91 +--
1 file changed, 88 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index cfb22a21a2e6..1c4
6 matches
Mail list logo
