Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Antoine Tenart
Hi Russell, On Tue, Jan 09, 2018 at 04:17:35PM +0100, Antoine Tenart wrote: > On Tue, Jan 09, 2018 at 02:44:48PM +, Russell King - ARM Linux wrote: > > On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > > > val |= MVPP2_GMAC_CONFIG_GMII_SPEED | > > > M

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Antoine Tenart
Hi Russell, On Tue, Jan 09, 2018 at 02:44:48PM +, Russell King - ARM Linux wrote: > On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and us

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Antoine Tenart
Hi Russell, On Tue, Jan 09, 2018 at 02:42:38PM +, Russell King - ARM Linux wrote: > On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and us

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses > nearly the same code path. Sorry, also... > @@ -4668,6 +4692,10 @@ static void mvpp2_p

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses > nearly the same code path. For 2500Base-X, do you report a speed of 2500Mbps through et

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Andrew Lunn
On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses > nearly the same code path. > > Signed-off-by: Antoine Tenart Thanks for adding the co

[PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Antoine Tenart
This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 50 +--- 1 file changed